|
Notes |
|
|
(0040050)
|
|
Thomas Laguzzi
|
|
2016-01-04 09:21
|
|
I attached a possible patch.
Two things I didn't know:
- how to switch the behavior between the generators. I added a virtual function to select the old/new behavior, but the name probably is wrong.
- Also, when using fastlink ,the new "Generate Full PDB files" option may be useful in some scenarios. Unfortunately that option doesn't have a command line switch, so I actually used a boolean TARGET_PROPERTY which I named LINK_FULL_PDBS , another probably wrong name
See the CmakeLists.txt attached which I used to check the results.
reference link:
(http://blogs.msdn.com/b/vcblog/archive/2015/10/16/debug-fastlink-for-vs2015-update-1.aspx [^]) |
|
|
|
(0040163)
|
|
Brad King
|
|
2016-01-08 14:19
|
|
|
|
|
(0040170)
|
|
Thomas Laguzzi
|
|
2016-01-09 10:32
|
|
|
tested: the commit works, it generates a correct XML |
|
|
|
(0040178)
|
|
Brad King
|
|
2016-01-11 09:53
|
|
|
Re 0015894:0040170: Great, thanks for testing. I've merged that change to 'master' and queued it for merge to 'release' for 3.4.2. |
|
|
|
(0040179)
|
|
Brad King
|
|
2016-01-11 09:54
|
|
|
|
|
(0040180)
|
|
Brad King
|
|
2016-01-11 09:58
|
|
Now we should be able to move on to /debug:fastlink support. After the cleanup linked in 0015894:0040179 the change can now be something like:
------------------------------------------------------------------------------
diff --git a/Source/cmVS14LinkFlagTable.h b/Source/cmVS14LinkFlagTable.h
index 1e781e8..29e3d86 100644
--- a/Source/cmVS14LinkFlagTable.h
+++ b/Source/cmVS14LinkFlagTable.h
@@ -177,6 +177,8 @@ static cmVS7FlagTable cmVS14LinkFlagTable[] =
{"UACUIAccess", "uiAccess='false'", "", "false", 0},
{"UACUIAccess", "uiAccess='true'", "", "true", 0},
{"ManifestEmbed", "manifest:embed", "", "true", 0},
+ {"GenerateDebugInformation", "DEBUG:FASTLINK", "", "DebugFastLink",
+ cmVS7FlagTable::CaseInsensitive},
{"GenerateDebugInformation", "DEBUG", "", "Debug",
cmVS7FlagTable::CaseInsensitive},
{"MapExports", "MAPINFO:EXPORTS", "", "true", 0},
------------------------------------------------------------------------------
However, that does not account for the "Generate Full PDB files" part of your changes. Since that involves a new interface to support a new feature, this issue tracker entry is not a good place to discuss it. Please read CONTRIBUTING.rst at the top of the source tree and raise discussion of /debug:fastlink on the developer list:
https://cmake.org/mailman/listinfo/cmake-developers [^] |
|
|
|
(0040181)
|
|
Brad King
|
|
2016-01-11 10:00
|
|
I'm marking this issue as 'resolved' because the main problem has been addressed. Support for /debug:fastlink is a new feature that is best discussed separately. Thanks!
|
|
|
|
(0040194)
|
|
Thomas Laguzzi
|
|
2016-01-11 15:32
|
|
thanks! I wrote a follow up in the mailing.
BTW the "next" branch works good, and also the patch in the comment works good to enable FastLink.
If you commit it, only the PDB option will be remaining, but it's not *so* important |
|
|
|
(0040195)
|
|
Brad King
|
|
2016-01-11 15:55
|
|
|
|
|
(0040275)
|
|
Brad King
|
|
2016-01-20 10:26
|
|
The change linked in 0015894:0040163 has been merged to 'release' and included in 3.4.2. That fixes the actual bug. Other changes discussed here are post-3.4 development and will be included in 3.5.
|
|
|
|
(0041243)
|
|
Kitware Robot
|
|
2016-06-10 14:21
|
|
|
This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page. |
|
cmake.patch (3,374) 2016-01-04 09:14