MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015747CMakeCMakepublic2015-09-16 16:042016-02-01 09:10
ReporterJames Johnston 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformVisual Studio 2008OSWindows 7OS Version
Product VersionCMake 3.4 
Target VersionCMake 3.4Fixed in VersionCMake 3.4 
Summary0015747: Regression: -Wno-dev doesn't work any more in CMake 3.4
DescriptionThe -Wno-dev option doesn't work any more in CMake 3.4.

Tested on the master branch, commit ID febeabbf0b221a19bd4bf16ba7620af22d8dba17
Steps To Reproduce1. Create a simple CMakeLists.txt like this:

cmake_minimum_required(VERSION 3.3.0 FATAL_ERROR)
project(DevWarn)
configure_file(infile outfile dummy_arg)

2. Try to configure it with -Wno-dev:

cmake "-GVisual Studio 9 2008" -Wno-dev ..\DevWarn

3. Observe the following error...

<snip>
CMake Warning (dev) at CMakeLists.txt:3 (configure_file):
  configure_file called with unknown argument(s):

   dummy_arg

This warning is for project developers. Use -Wno-dev to suppress it.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-16 16:04James JohnstonNew Issue
2015-09-16 16:13Brad KingTarget Version => CMake 3.4
2015-09-16 16:15Brad KingNote Added: 0039429
2015-09-16 18:29James JohnstonNote Added: 0039430
2015-09-17 09:46Brad KingNote Added: 0039436
2015-09-25 16:26Brad KingNote Added: 0039482
2015-09-25 16:26Brad KingAssigned To => Brad King
2015-09-25 16:26Brad KingStatusnew => resolved
2015-09-25 16:26Brad KingResolutionopen => fixed
2015-09-25 16:26Brad KingFixed in Version => CMake 3.4
2016-02-01 09:10Robert MaynardNote Added: 0040423
2016-02-01 09:10Robert MaynardStatusresolved => closed

Notes
(0039429)
Brad King   
2015-09-16 16:15   
Likely candidate:

 cmake: Add -W options to control deprecation warnings and errors
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c96fe0b4 [^]

but I've not tested. Do you mind bisecting?
(0039430)
James Johnston   
2015-09-16 18:29   
I can confirm that:


 cmake: Add -W options to control deprecation warnings and errors
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c96fe0b4 [^]

is the commit that caused this regression. The above test procedure reproduces on the above commit, but does not repro on its parent commit.
(0039436)
Brad King   
2015-09-17 09:46   
Relevant mailing list thread:

 Add command line options for deprecation message control
 http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/13798/focus=14426 [^]
(0039482)
Brad King   
2015-09-25 16:26   
After discussion on the list linked in 0015747:0039436 I've decided to revert the feature that caused this regression for now:

 Revert topic 'cmake-W-options'
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=81739e92 [^]

We've also added a test covering the regressed case:

 Tests: Add case for -Wdev and -Wno-dev with non-message() warnings
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bc3e1e4b [^]
(0040423)
Robert Maynard   
2016-02-01 09:10   
Closing resolved issues that have not been updated in more than 4 months.