MantisBT - CMake
View Issue Details
0015632CMakeModulespublic2015-06-25 08:302016-01-04 11:51
ycollet 
 
normalminoralways
closedno change required 
PCAll
CMake 3.2.2 
 
0015632: There are 2 modules with the same some: CheckIncludeFile and CheckIncludeFiles
There are 2 modules with the same some: CheckIncludeFile and CheckIncludeFiles
Both have the same come except for the variable names.
Should one should be remove ?
No tags attached.
Issue History
2015-06-25 08:30ycolletNew Issue
2015-06-25 08:37Brad KingNote Added: 0038974
2015-06-25 08:37Brad KingStatusnew => resolved
2015-06-25 08:37Brad KingResolutionopen => no change required
2015-06-25 08:50ycolletNote Added: 0038975
2015-06-25 09:42Brad KingNote Added: 0038976
2015-06-25 09:57ycolletNote Added: 0038979
2016-01-04 11:51Robert MaynardNote Added: 0040080
2016-01-04 11:51Robert MaynardStatusresolved => closed

Notes
(0038974)
Brad King   
2015-06-25 08:37   
CheckIncludeFile supports checking a single #include line. Later CheckIncludeFiles was added when we realized some headers need other headers to work so it supports multiple #include lines. The former is kept for compatibility with projects using it.
(0038975)
ycollet   
2015-06-25 08:50   
Maybe adding a little more documentation in CheckIncludeFiles:

Check if several files can be included

instead of

Check if the files can be included

And in CheckIncludeFile, a little recommandation:
"Please use CheckIncludeFiles instead of CheckIncludeFile"

It was not that clear to see the differences :)
(0038976)
Brad King   
2015-06-25 09:42   
I've revised the module documentation:

 Help: Revise CheckIncludeFile* documentation
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=81d58b0d [^]
(0038979)
ycollet   
2015-06-25 09:57   
Thanks a lot.
(0040080)
Robert Maynard   
2016-01-04 11:51   
Closing resolved issues that have not been updated in more than 4 months.