MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015413CMakeCMakepublic2015-02-20 11:092015-07-08 08:57
ReporterPeter Wu 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 3.1.3 
Target VersionCMake 3.3Fixed in VersionCMake 3.3 
Summary0015413: CheckStructHasMember generates an uninitialized variable warning
DescriptionRelated to bug 15203 (which is fixed in CMake 3.2).

The current check_struct_has_member macro (as can be found in CMake 3.2) generates an uninitialized variable warning (noticeable via Clangs static code analyzer).

A patch was proposed in http://www.cmake.org/Bug/view.php?id=15203#c37979, [^] but a valid concern was raised about invoking C++ constructors. Here is a new minimal patch which uses sizeof instead.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0015203closed Brad King CheckStructHasMember breaks on -Wunused-value 
Attached Filespatch 0001-CheckStructHasMember-fix-null-deref-warning.patch (893) 2015-02-20 11:09
https://public.kitware.com/Bug/file/5388/0001-CheckStructHasMember-fix-null-deref-warning.patch
Issue History
Date ModifiedUsernameFieldChange
2015-02-20 11:09Peter WuNew Issue
2015-02-20 11:09Peter WuFile Added: 0001-CheckStructHasMember-fix-null-deref-warning.patch
2015-02-20 11:21Brad KingAssigned To => Brad King
2015-02-20 11:21Brad KingStatusnew => assigned
2015-02-20 11:21Brad KingTarget Version => CMake 3.3
2015-02-20 11:24Brad KingRelationship addedrelated to 0015203
2015-02-20 11:36Brad KingNote Added: 0038010
2015-02-20 11:36Brad KingStatusassigned => resolved
2015-02-20 11:36Brad KingResolutionopen => fixed
2015-02-20 11:36Brad KingFixed in Version => CMake 3.3
2015-07-08 08:57Robert MaynardNote Added: 0039059
2015-07-08 08:57Robert MaynardStatusresolved => closed

Notes
(0038010)
Brad King   
2015-02-20 11:36   
Applied, thanks:

 CheckStructHasMember: fix null deref warning
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e1da4dc2 [^]
(0039059)
Robert Maynard   
2015-07-08 08:57   
Closing resolved issues that have not been updated in more than 4 months.