MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014804CMakeQtDialogpublic2014-03-12 06:412014-10-06 10:32
ReporterPeter Kuemmel 
Assigned ToBrad King 
PriorityhighSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionCMake 3.1Fixed in VersionCMake 3.1 
Summary0014804: Crash in QCMake.cxx
DescriptionQCMake.cxx line 120, extraGen is NULL:

if ( itm.Find("CMAKE_GENERATOR"))
      {
      const char* extraGen = cachem->GetCacheValue("CMAKE_EXTRA_GENERATOR");
      std::string curGen = cmExternalMakefileProjectGenerator::
                              CreateFullGeneratorName(itm.GetValue(), extraGen);
      this->setGenerator(QString::fromLocal8Bit(curGen.c_str()));
      }


Checking for CMAKE_GENERATOR and then getting CMAKE_EXTRA_GENERATOR?
Steps To ReproduceGenerator "Visual Studio 12 2013 Win64"
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 0001-cmake-gui-Fix-handling-of-missing-CMAKE_EXTRA_GENERA.patch (1,333) 2014-03-12 09:56
https://public.kitware.com/Bug/file/5092/0001-cmake-gui-Fix-handling-of-missing-CMAKE_EXTRA_GENERA.patch
Issue History
Date ModifiedUsernameFieldChange
2014-03-12 06:41Peter KuemmelNew Issue
2014-03-12 09:48Brad KingNote Added: 0035388
2014-03-12 09:56Brad KingFile Added: 0001-cmake-gui-Fix-handling-of-missing-CMAKE_EXTRA_GENERA.patch
2014-03-12 09:56Brad KingNote Added: 0035389
2014-03-12 09:57Brad KingProduct VersionCMake 3.0 =>
2014-03-12 09:57Brad KingTarget Version => CMake 3.1
2014-03-12 14:52Brad KingNote Added: 0035391
2014-03-13 16:41Brad KingAssigned To => Brad King
2014-03-13 16:41Brad KingStatusnew => resolved
2014-03-13 16:41Brad KingResolutionopen => fixed
2014-03-13 16:41Brad KingFixed in Version => CMake 3.1
2014-10-06 10:32Robert MaynardNote Added: 0036940
2014-10-06 10:32Robert MaynardStatusresolved => closed

Notes
(0035388)
Brad King   
2014-03-12 09:48   
It looks like that block was introduced way back in 2007:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cfa723d4#patch4 [^]

but the NULL was tolerated until the recent stringapi changes:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1a1b737c#patch4 [^]
(0035389)
Brad King   
2014-03-12 09:56   
Please try 0001-cmake-gui-Fix-handling-of-missing-CMAKE_EXTRA_GENERA.patch
(0035391)
Brad King   
2014-03-12 14:52   
Re 0014804:0035389: I've applied the patch here:

 cmake-gui: Fix handling of missing CMAKE_EXTRA_GENERATOR
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ae32622b [^]

However, I was not able to reproduce this crash on Linux so please test to make sure it is the only problem.
(0036940)
Robert Maynard   
2014-10-06 10:32   
Closing resolved issues that have not been updated in more than 4 months.