MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014762CMakeCPackpublic2014-02-17 16:572014-10-06 10:32
ReporterDavid Golub 
Assigned ToNils Gladitz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS Version7
Product VersionCMake 2.8.12.2 
Target VersionFixed in Version 
Summary0014762: Add support for customizing strings in Add/Remove Programs
DescriptionI'm submitting a patch to add support for customizing the various strings that appear in the Add/Remove Programs applet when packaging with Windows Installer XML.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 0001-CPack-WIX-Add-support-for-more-customization-of-Add-.patch (4,292) 2014-02-17 16:57
https://public.kitware.com/Bug/file/5076/0001-CPack-WIX-Add-support-for-more-customization-of-Add-.patch
Issue History
Date ModifiedUsernameFieldChange
2014-02-17 16:57David GolubNew Issue
2014-02-17 16:57David GolubFile Added: 0001-CPack-WIX-Add-support-for-more-customization-of-Add-.patch
2014-02-17 17:10Nils GladitzAssigned To => Nils Gladitz
2014-02-17 17:10Nils GladitzStatusnew => assigned
2014-02-18 03:06Nils GladitzNote Added: 0035138
2014-03-03 11:34Nils GladitzNote Added: 0035238
2014-03-03 11:34Nils GladitzStatusassigned => resolved
2014-03-03 11:34Nils GladitzResolutionopen => fixed
2014-10-06 10:32Robert MaynardNote Added: 0036928
2014-10-06 10:32Robert MaynardStatusresolved => closed

Notes
(0035138)
Nils Gladitz   
2014-02-18 03:06   
Thank you for the patch.
It looks definitely like something that the WiX generator should support.

I'd like to evaluate some alternatives before merging it though.

Since the way these properties are being added seems repetitive I am wondering
if something more generic could be added which preferably would also avoid frequently updating the template.

A list of properties and values that is used to generate an extra source file might be one option.

Also it might be nice if some of these could be mapped to generic (rather than WiX specific) CPACK_ variables.

E.g. the existing CPACK_PACKAGE_CONTACT might be appropriate for ARPCONTACT?

NSIS and other generators seem to have a couple of these too which might be consolidated.

Could just be wishful thinking though since it would have to be done without breaking existing behavior of the other generators.
(0035238)
Nils Gladitz   
2014-03-03 11:34   
Implemented by http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=378eb5b712bb8f131e62aa343e3ec27d446dc098 [^]
(0036928)
Robert Maynard   
2014-10-06 10:32   
Closing resolved issues that have not been updated in more than 4 months.