MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014188CMakeCMakepublic2013-06-02 18:242013-11-04 09:33
ReporterYichao Yu 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformLinuxOSArch LinuxOS Version
Product Version 
Target VersionCMake 2.8.12Fixed in VersionCMake 2.8.12 
Summary0014188: variable_watch print REMOVED_ACCESS instead of MODIFIED_ACCESS when set the value of the variable.
DescriptionSee summary and steps to reproduce.
Steps To Reproduceset(b "a")
variable_watch(b)
set(b "b")

expected output:
* Variable "b" was accessed using MODIFIED_ACCESS in: ....

actual output:
* Variable "b" was accessed using REMOVED_ACCESS in: ....
Additional Information
TagsNo tags attached.
Relationships
related to 0014187closed Brad King variable_watch with no command name will cause READ_ACCESS for all variables in the current scope. 
Attached Filespatch 0001-BUG-0014188-variable_watch-print-REMOVED_ACCESS-inst.patch (764) 2013-06-02 22:15
https://public.kitware.com/Bug/file/4777/0001-BUG-0014188-variable_watch-print-REMOVED_ACCESS-inst.patch
Issue History
Date ModifiedUsernameFieldChange
2013-06-02 18:24Yichao YuNew Issue
2013-06-02 22:13Yichao YuNote Added: 0033172
2013-06-02 22:15Yichao YuFile Added: 0001-BUG-0014188-variable_watch-print-REMOVED_ACCESS-inst.patch
2013-06-02 22:15Yichao YuNote Added: 0033173
2013-06-03 10:59Brad KingNote Added: 0033209
2013-06-03 10:59Brad KingAssigned To => Brad King
2013-06-03 10:59Brad KingStatusnew => resolved
2013-06-03 10:59Brad KingResolutionopen => fixed
2013-06-03 10:59Brad KingFixed in Version => CMake 2.8.12
2013-06-03 10:59Brad KingTarget Version => CMake 2.8.12
2013-06-03 13:26Brad KingRelationship addedrelated to 0014187
2013-11-04 09:33Robert MaynardNote Added: 0034356
2013-11-04 09:33Robert MaynardStatusresolved => closed

Notes
(0033172)
Yichao Yu   
2013-06-02 22:13   
looks like the bug is due to a missing entry in the AccessStrings

There are only 6 access names defined in cmVriableWatch.cxx. However, commit 9a5b4eba97628c53f051d653cdc8a301f5f32312 breaks binary compatibility and introduce cmVariableWatch:: UNKNOWN_VARIABLE_DEFINED_ACCESS, which shift all following names by one.
(0033173)
Yichao Yu   
2013-06-02 22:15   
patch attached.
(0033209)
Brad King   
2013-06-03 10:59   
Patch applied:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3d5bb381 [^]

and test added:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c63d3004 [^]

Thanks!
(0034356)
Robert Maynard   
2013-11-04 09:33   
Closing resolved issues that have not been updated in more than 4 months.