MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013959CMakeModulespublic2013-02-27 11:562016-06-10 14:31
ReporterJulian Ospald 
Assigned ToKitware Robot 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0013959: FindFreetype.cmake does not have a fallback (like pkgconfig or freetype-config)
DescriptionFreetype offers two ways to _correctly_ get the header and library location.

a) via pkgconfig file (freetype2.pc)
b) via freetype-config script

The lack of any of the above checks can and does lead to cmake configure failures, especially since freetype supports installing the headers into a custom location, because they contain ABI-specific information.

I am not suggesting to change the current module logic, but to just add a _fallback_ in case the current methods fail. And they already do for some usecases.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0014601closed Kitware Robot FindFreetype.cmake doesn't work with freetype 2.5.1 
related to 0014626closed Kitware Robot FindFreetype module needs a new maintainer and an overhaul 
Attached Filespatch FindFreetype.cmake.patch (1,150) 2013-02-28 11:55
https://public.kitware.com/Bug/file/4659/FindFreetype.cmake.patch
patch 0001-Support-finding-freetype2-using-pkg-config.patch (1,965) 2013-02-28 12:17
https://public.kitware.com/Bug/file/4660/0001-Support-finding-freetype2-using-pkg-config.patch
Issue History
Date ModifiedUsernameFieldChange
2013-02-27 11:56Julian OspaldNew Issue
2013-02-28 11:55Daniel ScharrerFile Added: FindFreetype.cmake.patch
2013-02-28 11:55Daniel ScharrerNote Added: 0032413
2013-02-28 12:13Michał GórnyNote Added: 0032414
2013-02-28 12:17Michał GórnyFile Added: 0001-Support-finding-freetype2-using-pkg-config.patch
2013-03-23 20:59Julian OspaldNote Added: 0032689
2013-11-27 11:09Brad KingRelationship addedrelated to 0014601
2013-11-27 11:11Brad KingAssigned To => Eric Wing
2013-11-27 11:11Brad KingStatusnew => assigned
2013-12-03 13:12Brad KingNote Added: 0034694
2013-12-03 13:12Brad KingAssigned ToEric Wing =>
2013-12-03 13:12Brad KingStatusassigned => backlog
2013-12-03 13:16Brad KingRelationship addedrelated to 0014626
2016-06-10 14:28Kitware RobotNote Added: 0042239
2016-06-10 14:28Kitware RobotStatusbacklog => resolved
2016-06-10 14:28Kitware RobotResolutionopen => moved
2016-06-10 14:28Kitware RobotAssigned To => Kitware Robot
2016-06-10 14:31Kitware RobotStatusresolved => closed

Notes
(0032413)
Daniel Scharrer   
2013-02-28 11:55   
Hi, my project uses CMake and Freetype and with the current FindFreetype.cmake it will inevitably break when a distro moves the Freetype headers to an architecture-specific location. I hope this can be fixed in CMake before then.

I have attached a patch that uses the CMake's PkgConfig module to set get hints for the find_path and find_library calls in FindFreetype.cmake, like it is already used in other Find modules. I have however not tested that this will correctly pick up arch-specific header locations.
(0032414)
Michał Górny   
2013-02-28 12:13   
Thanks for the patch, Daniel. You missed the includedir in the first block. I will attach a fixed and reindented patch in a minute ;).
(0032689)
Julian Ospald   
2013-03-23 20:59   
At least this remains proof that cmake devs don't care about fixing their broken module logic.
(0034694)
Brad King   
2013-12-03 13:12   
The FindFreetype.cmake module needs a new volunteer maintainer and a major overhaul:

 http://www.cmake.org/Wiki/CMake:Module_Maintainers [^]

Moving this issue to the backlog until that happens.
(0042239)
Kitware Robot   
2016-06-10 14:28   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.