MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013649CMakeCMakepublic2012-11-03 17:112013-04-17 08:54
ReporterR Wackerbarth 
Assigned ToBrad King 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSMac OS XOS Version
Product Version 
Target VersionCMake 2.8.11Fixed in VersionCMake 2.8.11 
Summary0013649: OSName is reported incorrectly
DescriptionIn 2.8.9, and earlier, the OSName was reported as "Mac OS X".
In 2.8.10, it is now reported as "Mac"

sw_vers reports "Mac OS X"
Steps To ReproduceLook at dashboard entries. The difference is quite visible because CDash now fails to flag the entries with the Apple logo.
Additional InformationThis is a result of the changes to SystemInformation recently imported from KWSys.

Those changes were introduced in commit 857bda17548eb4efe3bd54f00b0b024489f50ca5 on May 29, 2012.


<Site BuildName="fix-SystemInformation-gb90f2+MacOSX-10.8.2-Ninja-gcc-4.2.1"
    BuildStamp="20121103-1141-Experimental"
    Name="MacBookPro.NFSNet"
    Generator="ctest-2.8.10.20121101-gafe0"
    CompilerName=""
    OSName="Mac"
    Hostname="experimental.squaredancetexas.org"
    OSRelease="10.8.2"
    OSVersion="12C60"
    OSPlatform="x86_64"
    ... snip ...

<Site BuildName="fix-SystemInformation-gb90f2+MacOSX-10.8.2-gcc-4.2.1"
    BuildStamp="20121103-0547-Experimental"
    Name="MacBookPro.NFSNet"
    Generator="ctest-2.8.9"
    CompilerName=""
    OSName="Mac OS X"
    Hostname="experimental.squaredancetexas.org"
    OSRelease="10.8.2"
    OSVersion="12C60"
    ... snip ...

$ sw_vers
ProductName: Mac OS X
ProductVersion: 10.8.2
BuildVersion: 12C60
$ sw_vers -productName
Mac OS X
$ sw_vers -productVersion
10.8.2
$ sw_vers -buildVersion
12C60
$
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-11-03 17:11R WackerbarthNew Issue
2012-11-03 17:30Rolf Eike BeerNote Added: 0031406
2012-11-03 17:37R WackerbarthNote Added: 0031407
2012-11-03 17:54David ColeNote Added: 0031408
2012-11-03 18:54David ColeNote Added: 0031409
2012-11-05 11:16Brad KingNote Added: 0031432
2012-11-05 11:16Brad KingAssigned To => Brad King
2012-11-05 11:16Brad KingStatusnew => assigned
2012-11-05 11:16Brad KingProduct VersionCMake 2.8.10 =>
2012-11-05 11:16Brad KingTarget Version => CMake 2.8.11
2012-11-05 12:05Brad KingNote Added: 0031433
2012-11-06 09:38Brad KingNote Added: 0031473
2012-11-06 09:38Brad KingStatusassigned => resolved
2012-11-06 09:38Brad KingResolutionopen => fixed
2012-11-06 09:38Brad KingTarget VersionCMake 2.8.11 =>
2012-11-06 15:17David ColeFixed in Version => CMake 2.8.11
2012-11-06 15:17David ColeTarget Version => CMake 2.8.11
2013-04-17 08:54Robert MaynardNote Added: 0032862
2013-04-17 08:54Robert MaynardStatusresolved => closed

Notes
(0031406)
Rolf Eike Beer   
2012-11-03 17:30   
From which repository is that commit id? My cmake repo doesn't know it.
(0031407)
R Wackerbarth   
2012-11-03 17:37   
The commit that I referenced is in the KWSys repository. A collection of changes were brought into CMake in late October.
(0031408)
David Cole   
2012-11-03 17:54   
This does not happen for me with CMake 2.8.10, the official release.

It looks like this is part of what got merged to 'next' right after the release, so it's presently in 'next'.

Thanks for catching it quickly.
(0031409)
David Cole   
2012-11-03 18:54   
I have also verified that this does NOT happen for me with a build based on today's 'master', but it DOES happen with a 'next' build...
(0031432)
Brad King   
2012-11-05 11:16   
The offending change was made in KWSys months ago. Only in post-2.8.10 development did I start bringing them into CMake. Currently they're only in "next". I'll look at resolving this before merging to CMake for permanent inclusion in master.
(0031433)
Brad King   
2012-11-05 12:05   
This should fix it:

 http://review.source.kitware.com/#/c/8351/ [^]
(0031473)
Brad King   
2012-11-06 09:38   
This commit to KWSys fixes the issue:

 http://public.kitware.com/gitweb?p=KWSys.git;a=commitdiff;h=2c46f562 [^]

It is imported into CMake here:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cd83da97 [^]
(0032862)
Robert Maynard   
2013-04-17 08:54   
Closing resolved issues that have not been updated in more than 4 months.