MantisBT - CMake
View Issue Details
0012508CMakeCMakepublic2011-10-10 07:002011-12-16 17:21
David Coppa 
Alex Neundorf 
normaltweakalways
closedfixed 
OpenBSD
CMake 2.8.6 
CMake 2.8.7CMake 2.8.7 
0012508: Cosmetic fix for cmake configure (Tests/FindPackageModeMakefileTest/CMakeLists.txt)
On OpenBSD, during bootstrap for cmake 2.8.6, you have the following output:

<...>
-- Looking for a Fortran compiler
-- Looking for a Fortran compiler - /usr/local/bin/g77
make: unknown option -- v
usage: make [-BeiknPqrSst] [-D variable] [-d flags] [-f makefile]
            [-I directory] [-j max_jobs] [-m directory] [-V variable]
            [NAME=value] [target ...]
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - found
<...>

That's ugly to see. The attached diff fixes this "issue".
I think it's acceptable, since GNU make sends its "-v" output to stdout.


diff --git a/Tests/FindPackageModeMakefileTest/CMakeLists.txt b/Tests/FindPackageModeMakefileTest/CMakeLists.txt
index def8d63..3674f0e 100644
--- a/Tests/FindPackageModeMakefileTest/CMakeLists.txt
+++ b/Tests/FindPackageModeMakefileTest/CMakeLists.txt
@@ -7,6 +7,7 @@ if(UNIX AND "${CMAKE_GENERATOR}" MATCHES "Makefile")
   # is AFAIK a GNU make extension. Alex
   execute_process(COMMAND ${CMAKE_MAKE_PROGRAM} -v
                   OUTPUT_VARIABLE makeVersionOutput
+ ERROR_QUIET
                   TIMEOUT 10)
   string(TOUPPER "${makeVersionOutput}" MAKE_VERSION_OUTPUT)
   if("${MAKE_VERSION_OUTPUT}" MATCHES ".*GNU MAKE.*")

No tags attached.
diff FindPackageModeMakefileTest.diff (759) 2011-10-10 07:00
https://public.kitware.com/Bug/file/4074/FindPackageModeMakefileTest.diff
Issue History
2011-10-10 07:00David CoppaNew Issue
2011-10-10 07:00David CoppaFile Added: FindPackageModeMakefileTest.diff
2011-10-10 09:27Brad KingAssigned To => Alex Neundorf
2011-10-10 09:27Brad KingStatusnew => assigned
2011-10-12 16:26Alex NeundorfNote Added: 0027574
2011-10-12 16:26Alex NeundorfStatusassigned => closed
2011-10-12 16:26Alex NeundorfResolutionopen => fixed
2011-10-12 16:26Alex NeundorfDescription Updatedbug_revision_view_page.php?rev_id=435#r435
2011-12-16 17:21David ColeFixed in Version => CMake 2.8.7
2011-12-16 17:21David ColeTarget Version => CMake 2.8.7

Notes
(0027574)
Alex Neundorf   
2011-10-12 16:26   
Thanks, I committed the patch and merged it into next.

Alex