MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012440CMake(No Category)public2011-09-01 16:082012-02-06 06:07
ReporterThomas Jarosch 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.5 
Target VersionFixed in Version 
Summary0012440: Fix various issues detected by cppcheck
DescriptionHi there,

I've given cmake a "cppcheck" lint run and
fixed various issues. Please consider the attached patches.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 0001-Fix-memory-leak-on-error.patch (2,092) 2011-09-01 16:08
https://public.kitware.com/Bug/file/4039/0001-Fix-memory-leak-on-error.patch
patch 0002-Fix-file-descriptor-leak-on-error.patch (1,048) 2011-09-01 16:08
https://public.kitware.com/Bug/file/4040/0002-Fix-file-descriptor-leak-on-error.patch
patch 0003-Fix-off-by-one-memory-access-error.patch (887) 2011-09-01 16:08
https://public.kitware.com/Bug/file/4041/0003-Fix-off-by-one-memory-access-error.patch
Issue History
Date ModifiedUsernameFieldChange
2011-09-01 16:08Thomas JaroschNew Issue
2011-09-01 16:08Thomas JaroschFile Added: 0001-Fix-memory-leak-on-error.patch
2011-09-01 16:08Thomas JaroschFile Added: 0002-Fix-file-descriptor-leak-on-error.patch
2011-09-01 16:08Thomas JaroschFile Added: 0003-Fix-off-by-one-memory-access-error.patch
2011-09-02 11:17Brad KingAssigned To => Brad King
2011-09-02 11:17Brad KingStatusnew => assigned
2011-09-02 11:17Brad KingNote Added: 0027320
2011-09-02 11:21Brad KingNote Added: 0027321
2011-09-02 11:21Brad KingStatusassigned => resolved
2011-09-02 11:21Brad KingResolutionopen => fixed
2012-02-06 06:07David ColeNote Added: 0028488
2012-02-06 06:07David ColeStatusresolved => closed

Notes
(0027320)
Brad King   
2011-09-02 11:17   
Thanks. I've applied the patch series locally for testing.
(0027321)
Brad King   
2011-09-02 11:21   
Applied, thanks!

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f47393c6 [^]
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4868921b [^]
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d1751fbf [^]
(0028488)
David Cole   
2012-02-06 06:07   
Closing resolved issues that have not been updated in more than 4 months.