MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012260CMakeCTestpublic2011-06-09 08:312012-02-06 06:07
ReporterJohannes Stallkamp 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
Platformx86OSUbuntu LinuxOS Version10.04
Product VersionCMake 2.8.4 
Target VersionCMake 2.8.6Fixed in VersionCMake 2.8.6 
Summary0012260: CTest incorrectly parses valgrind/memcheck output if numbers contain a comma
DescriptionCTest 2.8.4 incorrectly parses valgrind's memcheck
output because it does not always take into account that numbers
reported by valgrind can be larger than 1,000 and then will contain a
comma as thousand-delimiter. Therefore, many errors/potential errors
are not correctly reported in the dashboard.

Patch attached.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 0001-Fixed-valgrind-parsing.patch (2,748) 2011-06-09 08:31
https://public.kitware.com/Bug/file/3924/0001-Fixed-valgrind-parsing.patch
patch 0001-CTest-Fixed-valgrind-output-parsing-12260.patch (3,192) 2011-09-05 14:33
https://public.kitware.com/Bug/file/4043/0001-CTest-Fixed-valgrind-output-parsing-12260.patch
Issue History
Date ModifiedUsernameFieldChange
2011-06-09 08:31Johannes StallkampNew Issue
2011-06-09 08:31Johannes StallkampFile Added: 0001-Fixed-valgrind-parsing.patch
2011-06-09 14:00Brad KingNote Added: 0026810
2011-06-13 14:43David ColeAssigned To => David Cole
2011-06-13 14:43David ColeStatusnew => assigned
2011-08-22 08:13David ColeTarget Version => CMake 2.8.6
2011-09-05 14:24David ColeNote Added: 0027353
2011-09-05 14:33David ColeFile Added: 0001-CTest-Fixed-valgrind-output-parsing-12260.patch
2011-09-05 14:35David ColeNote Added: 0027358
2011-09-05 15:01David ColeNote Added: 0027359
2011-09-05 15:01David ColeStatusassigned => resolved
2011-09-05 15:01David ColeFixed in Version => CMake 2.8.6
2011-09-05 15:01David ColeResolutionopen => fixed
2012-02-06 06:07David ColeNote Added: 0028493
2012-02-06 06:07David ColeStatusresolved => closed

Notes
(0026810)
Brad King   
2011-06-09 14:00   
If the numbers are large than 10^6 then might there be more commas?

Perhaps the expression should be of the form

  [0-9,]*

to allow any number of digits and commas?
(0027353)
David Cole   
2011-09-05 14:24   
Is everybody listening here ok with it if I follow Brad's suggestion and use "[0-9,]" instead, so that it still works with very large numbers...?

If I push a fix to 'next' this afternoon, is there anybody who can test it for us and verify that it works with larger numbers?

Thanks.
(0027358)
David Cole   
2011-09-05 14:35   
I uploaded a new patch that replaces old occurrences of "[0-9][0-9]*" with the simpler, yet more inclusive "[0-9,]+" -- does that seem reasonable here?

I will push my attached patch to 'next' after running the test suite locally. Please let me know if you have objections to this fix. Credit still goes to Johannes as the author of the patch.
(0027359)
David Cole   
2011-09-05 15:01   
I've pushed this commit to 'next' to fix this issue. Differs from originally submitted patch.

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=eb4af16298a9b456c0fd8df6e20727ce7f6f422c [^]

Please test and let me know if it's equivalent/ok with you...


Thanks
(0028493)
David Cole   
2012-02-06 06:07   
Closing resolved issues that have not been updated in more than 4 months.