MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012256CMakeCPackpublic2011-06-08 10:492016-06-10 14:31
ReporterDaniel Franke 
Assigned ToKitware Robot 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionFixed in Version 
Summary0012256: cpack should sanitize component names
DescriptionWorking on an Windows NSIS installer with components. Consider:

  add_executable(targetname ...)
  install (targetname COMPONENT "foo/bar")
  cpackk_add_component("foo/bar" DISPLAY_NAME "blabla" ...)

this results in CPackConfig.cmake:

# Configuration for component "foo/bar"
SET(CPACK_COMPONENT_FOO/BAR_DISPLAY_NAME "blabla")

The component "foo/bar" does not show up in the installer afterwards. The component names should probably be sanitised with regard to '/' and possibly other characters not allowed in variable names?!

Observed with cmake 2.8.1 on Windows, NSIS version 2.46.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-06-08 10:49Daniel FrankeNew Issue
2011-06-08 11:04Daniel FrankeNote Added: 0026763
2012-08-11 11:09David ColeStatusnew => backlog
2012-08-11 11:09David ColeNote Added: 0030264
2016-06-10 14:28Kitware RobotNote Added: 0041847
2016-06-10 14:28Kitware RobotStatusbacklog => resolved
2016-06-10 14:28Kitware RobotResolutionopen => moved
2016-06-10 14:28Kitware RobotAssigned To => Kitware Robot
2016-06-10 14:31Kitware RobotStatusresolved => closed

Notes
(0026763)
Daniel Franke   
2011-06-08 11:04   
Additional observation: component name with a '-' result in proper cmake variables and are passed on to NSIS, but then NSIS complains:

Error: invalid characters in variable name "foo-bar_selected", use only characters [a-z][A-Z][0-9] and '_'
(0030264)
David Cole   
2012-08-11 11:09   
Sending old, never assigned issues to the backlog.

(The age of the bug, plus the fact that it's never been assigned to anyone means that nobody is actively working on it...)

If an issue you care about is sent to the backlog when you feel it should have been addressed in a different manner, please bring it up on the CMake mailing list for discussion. Sign up for the mailing list here, if you're not already on it: http://www.cmake.org/mailman/listinfo/cmake [^]

It's easy to re-activate a bug here if you can find a CMake developer who has the bandwidth to take it on, and ferry a fix through to our 'next' branch for dashboard testing.
(0041847)
Kitware Robot   
2016-06-10 14:28   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.