|
(0025879)
|
|
Michael Wild
|
|
2011-03-23 05:34
|
|
A few remarks:
* in new code, lower-case commands are preferred (e.g. find_path())
* paths in ENV should go into the PATHS list, not into HINTS. The latter are intended for computed paths (e.g. by querying pkg_config or guessing a library path based on the include path). For the find_path() call, append /include to them, for the find_library call, append /lib. By default CMake should also search /lib64 where appropriate (e.g. it does not on Debian based Linux distros, where it would be wrong to do so).
* set PATH_SUFFIXES in the find_path() call to SDL12 SDL11 SDL.
* remove the standard paths from the PATHS list in the find_* calls. Take a look at the files ${CMAKE_ROOT}/Modules/Platform/*.cmake (in particular, the variables CMAKE_SYSTEM_PREFIX_PATH, CMAKE_SYSTEM_INCLUDE_PATH, CMAKE_SYSTEM_LIBRARY_PATH). A few prefixes I can easily spot are: ~/Library/Frameworks, /Library/Frameworks, /usr/local, /usr, /sw, /opt/local, /opt/csw, /opt. Come to think of it, that looks like you can remove them all (except for the ENV paths, that is).
* use the FindPackageHandleStandardArgs module instead of manually setting SDLGFX_FOUND.
* your module should set the un-cached variables SDLGFX_INCLUDE_DIRS and SDLGFX_LIBRARIES. |
|
|
(0030246)
|
|
David Cole
|
|
2012-08-11 11:09
|
|
Sending old, never assigned issues to the backlog.
(The age of the bug, plus the fact that it's never been assigned to anyone means that nobody is actively working on it...)
If an issue you care about is sent to the backlog when you feel it should have been addressed in a different manner, please bring it up on the CMake mailing list for discussion. Sign up for the mailing list here, if you're not already on it: http://www.cmake.org/mailman/listinfo/cmake [^]
It's easy to re-activate a bug here if you can find a CMake developer who has the bandwidth to take it on, and ferry a fix through to our 'next' branch for dashboard testing.
|
|
FindSDL_gfx.cmake (2,030) 2011-03-23 04:48