MantisBT - ITK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011205ITKpublic2010-09-03 17:392010-12-04 23:24
ReporterMatthew McCormick 
Assigned Tolorensen 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionITK-4-A1 
Target VersionFixed in Version 
Resolution Date
Sprint
Sprint Statusbacklog
Summary0011205: itkSampleToHistogramFilter does not check for HistogramSize input correctly.
DescriptionIn GenerateData(), the filter checks to see if the inputs, which are wrapped in SimpleDataObjectDecorator's, are NULL. However, values get initialized in the constructor. The test does not fail because it just checks to see if an exception gets thrown, not which exception is thrown.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-09-03 17:39Matthew McCormickNew Issue
2010-09-03 18:47Matthew McCormickNote Added: 0022086
2010-09-04 19:43Luis IbanezNote Added: 0022090
2010-09-04 19:43Luis IbanezStatusnew => assigned
2010-09-04 19:43Luis IbanezAssigned To => Luis Ibanez
2010-11-07 02:10Luis IbanezNote Added: 0022999
2010-11-07 02:10Luis IbanezAssigned ToLuis Ibanez => lorensen
2010-12-04 23:23Matthew McCormickNote Added: 0023718
2010-12-04 23:24Matthew McCormickSprint Status => backlog
2010-12-04 23:24Matthew McCormickNote Added: 0023719
2010-12-04 23:24Matthew McCormickStatusassigned => closed
2010-12-04 23:24Matthew McCormickResolutionopen => fixed

Notes
(0022086)
Matthew McCormick   
2010-09-03 18:47   
Gerrit patch here:
http://review.source.kitware.com/#change,40 [^]
(0022090)
Luis Ibanez   
2010-09-04 19:43   
The method of parsing the messages from Exceptions in order to figure out what they are is contrary to the principle of using RTTI for identifying exceptions.

The patch has been modified in
http://review.source.kitware.com/#change,40 [^]

to include a new set of specialized Exceptions that will be distinguishable solely on the basis of their type, without a need for parsing their error messages.

Several macros were added to the itkMacro.h file in order to facilitate the creation of specialized exceptions.
(0022999)
Luis Ibanez   
2010-11-07 02:10   
We should bring this discussion to the developers mailing list, and maybe include it in one of the tcons.
(0023718)
Matthew McCormick   
2010-12-04 23:23   
Merged here
http://review.source.kitware.com/#change,356 [^]
(0023719)
Matthew McCormick   
2010-12-04 23:24   
Fixed here http://review.source.kitware.com/#change,356 [^]
Change-Id: Ie3db93a150fa57264d979ca75613aa839d2de9f4