MantisBT - ITK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010207ITKpublic2010-01-29 17:162010-04-01 22:01
ReporterHans Johnson 
Assigned ToGaetan Lehmann 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionITK-3-16 
Target VersionFixed in VersionITK-3-16 
Resolution Date
Sprint
Sprint Status
Summary0010207: Minor change to cable swig to silence 100's of compiler warnings
DescriptionOur builds of ITK are causing 100's of compiler warnings when wrapping is turned on. We've identified a work around that seems to work properly (all tests pass), and it also silences all the warnings.

Index: Utilities/CableSwig/SWIG/Source/Modules/tcl8.cxx
===================================================================
RCS file: /cvsroot/CableSwig/CableSwig/SWIG/Source/Modules/tcl8.cxx,v
retrieving revision 1.6
diff -r1.6 tcl8.cxx
514c514
< Printf(df->code,"Tcl_SetResult(interp, \"No matching function for overloaded '%s'\", TCL_STATIC);\n", iname);
---
> Printf(df->code,"Tcl_SetObjResult(interp, Tcl_NewStringObj(\"No matching function for overloaded '%s'\", -1));\n", iname);


We would greatly appreciate it if this patch could be applied.

Thanks,
Hans
Steps To Reproduce
Additional Information

[ 28%] Built target brains3_real
[ 36%] Built target test_wrapper_scripts
Scanning dependencies of target ItkBrainsGlueTcl
[ 36%] Building CXX object src/IPLtoITKcmd/ItkBrainsGlue/Wrapping/CMakeFiles/ItkBrainsGlueTcl.dir/wrap_ItkBrainsGlueTclTcl.cxx.o

[ 36%] Building CXX object src/IPLtoITKcmd/ItkBrainsGlue/Wrapping/CMakeFiles/ItkBrainsGlueTcl.dir/wrap_itkBrainsLabelStatisticsImageFilterTcl.cxx.o
/.../BRAINS-COMPILE/Linux/FAST-build/BRAINS3-build/src/IPLtoITKcmd/ItkBrainsGlue/Wrapping/wrap_itkBrainsLabelStatisticsImageFilterTcl.cxx: In function `int _wrap_itkBrainsLabelStatisticsImageFilterIF2IUC2_GetNameOfClass(void*, Tcl_Interp*, int, Tcl_Obj* const*)':

/.../BRAINS-COMPILE/Linux/FAST-build/BRAINS3-build/src/IPLtoITKcmd/ItkBrainsGlue/Wrapping/wrap_itkBrainsLabelStatisticsImageFilterTcl.cxx:1387: warning: cast from `const char*' to `char*' discards qualifiers from pointer target type

/.../BRAINS-COMPILE/Linux/FAST-build/BRAINS3-build/src/IPLtoITKcmd/ItkBrainsGlue/Wrapping/wrap_itkBrainsLabelStatisticsImageFilterTcl.cxx: In function `int _wrap_itkBrainsLabelStatisticsImageFilterIUC3ISS3_GetNameOfClass(void*, Tcl_Interp*, int, Tcl_Obj* const*)':

TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-01-29 17:16Hans JohnsonNew Issue
2010-01-30 09:55Luis IbanezStatusnew => assigned
2010-01-30 09:55Luis IbanezAssigned To => Luis Ibanez
2010-01-30 10:13Luis IbanezAssigned ToLuis Ibanez => Brad King
2010-02-01 08:20Brad KingAssigned ToBrad King => Gaetan Lehmann
2010-02-01 08:21Brad KingNote Added: 0019383
2010-02-01 08:22Brad KingNote Added: 0019384
2010-04-01 22:01Hans JohnsonNote Added: 0020057
2010-04-01 22:01Hans JohnsonStatusassigned => closed
2010-04-01 22:01Hans JohnsonResolutionopen => fixed
2010-04-01 22:01Hans JohnsonFixed in Version => ITK-3-16

Notes
(0019383)
Brad King   
2010-02-01 08:21   
Gaetan committed this as SWIG/Source/Modules/tcl8.cxx revision 1.7.

COMP: Bug 0010207. Fix warning: cast from 'const char*' to 'char*' discards qualifiers from pointer target type. Patch from Hans Johnson.
(0019384)
Brad King   
2010-02-01 08:22   
I don't remember enough about the Tcl object API off the top of my head. Are you sure this doesn't leak the Tcl string object?
(0020057)
Hans Johnson   
2010-04-01 22:01   
This seems to be working well for over two months. It has silences 100's of warnings.