<div dir="ltr">Current patch:<br><a href="http://pastebin.com/DfGZtGQT">http://pastebin.com/DfGZtGQT</a><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Nov 1, 2013 at 10:35 PM, physhh . <span dir="ltr"><<a href="mailto:physhh@gmail.com" target="_blank">physhh@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>I've tried to implement it in the same way as CCMake seem to do it. <br>Because I can't compare it => <br>
Could somone with access to ccmake test this:<br></div>- Start CCMake with -D foo=123<br>
</div><div>- Configure<br></div><div>- Question: Is foo displayed in the variable list?<br></div><div>- Add/Edit foo to some other value<br></div><div>- Configure<br></div><div>- Question: Was foo overwritten with "123"?</div>
<br></div>Thanks<br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Nov 1, 2013 at 7:02 PM, Matthew Woehlke <span dir="ltr"><<a href="mailto:matthew.woehlke@kitware.com" target="_blank">matthew.woehlke@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On 2013-11-01 11:39, physhh . wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
that's interesting. I'm currently at a windows only machine so i can't<br>
check out ccmake but can only lookup the source. It appears that ALL<br>
parameters get "forwarded" to cmake - at least that's what<br>
<br>
cmCursesMainForm.cxx:52<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
this->CMakeInstance->SetArgs(<u></u>this->Args);<br>
</blockquote>
<br>
looks to me.<br>
Why do you think that a simple forward is not enough? ccmake seems to do it<br>
exactly that way?<br>
</blockquote>
<br></div>
I don't know enough of the guts to know how values initially specified in ccmake / cmake-gui get passed to CMake. Where you could get into trouble is, say, you pass -DBOOST_ROOT=/some/ptah, realize you've made a mistake (e.g. 'ptah' -> 'path') and fix it in the gui before running cmake. Now does cmake see the original value or the corrected value?<br>
<br>
That's where it *might* go sideways. But it might also be perfectly safe to just pass them through, e.g. if the corrected value is passed also as a -D argument later in the list.<br>
<br>
However, what I was mainly getting at is that cmake-gui should also process the -D, etc., as I am pretty sure ccmake does, so that it can display those values and/or make appropriate use of the arguments.<div>
<div><br>
<br>
-- <br>
Matthew<br>
<br>
--<br>
<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/<u></u>CMake_FAQ</a><br>
<br>
Kitware offers various services to support the CMake community. For more information on each offering, please visit:<br>
<br>
CMake Support: <a href="http://cmake.org/cmake/help/support.html" target="_blank">http://cmake.org/cmake/help/<u></u>support.html</a><br>
CMake Consulting: <a href="http://cmake.org/cmake/help/consulting.html" target="_blank">http://cmake.org/cmake/help/<u></u>consulting.html</a><br>
CMake Training Courses: <a href="http://cmake.org/cmake/help/training.html" target="_blank">http://cmake.org/cmake/help/<u></u>training.html</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/<u></u>opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/<u></u>listinfo/cmake</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>