<div dir="ltr">Hi Chris, <div><br></div><div style>To make the process easier, could you create a small project on Gtihub. We would then be able to comment on a line-by-line basis.</div><div style><br></div><div style>Hth</div>
<div style>Jc</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Feb 23, 2013 at 11:37 PM, Chris Stankevitz <span dir="ltr"><<a href="mailto:chrisstankevitz@gmail.com" target="_blank">chrisstankevitz@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
Would you please critique my CMakeLists.txt and <a href="http://helloConfig.cmake.in" target="_blank">helloConfig.cmake.in</a><br>
files? I am particularly interested in comments that will help me fix<br>
these problems:<br>
<br>
- In <a href="http://helloConfig.cmake.in" target="_blank">helloConfig.cmake.in</a>, I assume static libraries will be built<br>
(".a"). I imaging a better approach would make no assumptions about<br>
this.<br>
<br>
- In <a href="http://helloConfig.cmake.in" target="_blank">helloConfig.cmake.in</a>, I assume ${PREFIX} will expand to the<br>
installed prefix, but it does not.<br>
<br>
- I type the same expression many times:<br>
"hello-${hello_VERSION_MAJOR}.${hello_VERSION_MINOR}". I imagine the<br>
better approach would derive this expression from some built-in cmake<br>
variables or from a variable I create.<br>
<br>
- INSTALL is looking for helloConfig.cmake in the source directory but<br>
it is in the build directory.<br>
<br>
- Any other comments you have<br>
<br>
Thank you!<br>
<span class="HOEnZb"><font color="#888888"><br>
Chris<br>
</font></span><br>--<br>
<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>+1 919 869 8849<br>
</div>