<div class="gmail_quote">On Tue, Apr 17, 2012 at 6:43 PM, Clifford Yapp <span dir="ltr"><<a href="mailto:cliffyapp@gmail.com">cliffyapp@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Tue, Apr 17, 2012 at 4:59 PM, David Cole <<a href="mailto:david.cole@kitware.com">david.cole@kitware.com</a>> wrote:<br>
</div><div class="im">> Hello CMake Ninja fans,<br>
><br>
> We are going to be creating the CMake 2.8.8 final release tomorrow. However,<br>
> there are issues reported for the ninja generator. Does anybody consider<br>
> them "showstoppers" ??<br>
<br>
</div><div class="im">David,<br>
<br>
Does the latest CMake 2.8.8 source tree have this fix?<br>
<br>
<a href="http://www.cmake.org/pipermail/cmake/2012-April/049772.html" target="_blank">http://www.cmake.org/pipermail/cmake/2012-April/049772.html</a><br>
<br>
Even if it's not the ideal fix, I just tested it and it does seem to<br>
address one of the ninja clean target issues I was seeing. Not really<br>
a show-stopper (definitely not worth another RC, if that's what would<br>
be involved) but would be a nice-to-have.<br></div></blockquote><div><br></div><div>No -- that change is not in CMake's main repo yet. It is not in the 'release' branch, nor is it in master or next.</div><div>
<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
<br>
CY<br>
<br>
P.S. - Is it expected that Ninja respect the<br>
ADDITIONAL_MAKE_CLEAN_FILES property, or is there a separate property<br>
for each generator? If the latter, is there some "common" property<br>
that can be used to have all generators' clean rules remove the files?<br></div></blockquote><div><br></div><div>I would expect this to work. The Ninja generator still needs some work before it hits 100% parity with the Unix Makefiles generator.</div>
<div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
</div>--<br>
<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
</blockquote></div><br>