<div><br></div><div>Thank you David & Alex,</div><div><br></div>I also have the
ASM_NASM language enabled in my CMakeLists.txt files, and this works for Makefile generators so I'm not sure I understand why there is more work involved in that area of the code ? It seems to handle nasm fine to me.<div>
<br></div><div>My problem was only with XCode, and regardless of the Makefile generators, I think the CMake XCode generator should know about the nasm file type and set the correct field in the XCode project. David's suggestions looks good to me and I can submit a patch later today if you guys agree this is the correct course of action ?</div>
<div><br></div><div>If I missed something about the Makefile generators issue please feel free to explain it to me again and I can also patch there if something is indeed required.<br clear="all"><br>Cheers,<br>Damien.<br>
<br><br><div class="gmail_quote">On Tue, Apr 10, 2012 at 8:43 PM, Alexander Neundorf <span dir="ltr"><<a href="mailto:a.neundorf-work@gmx.net">a.neundorf-work@gmx.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Tuesday 10 April 2012, David Cole wrote:<br>
> If you would like to construct a git commit (based on the present<br>
> 'master' branch), and then attach the patch produced by:<br>
><br>
> git format-patch -1<br>
><br>
> to the issue at <a href="http://public.kitware.com/Bug/view.php?id=9126" target="_blank">http://public.kitware.com/Bug/view.php?id=9126</a>, then<br>
> we will consider it for inclusion in a future CMake release.<br>
><br>
> Seems like the easiest thing to do, at least for your case, would<br>
> simply be add the "nasm" file extension to the code in the recently<br>
> factored-out function GetSourcecodeValueFromFileExtension in<br>
> Source/cmGlobalXCodeGenerator.cxx. Adding more known file types to<br>
> that function will help us keep CMakeLists from being cluttered with<br>
> too many required source file properties.<br>
<br>
</div>Handling of nasm files should be coupled to having the ASM_NASM language<br>
enabled, that's what has to be done for the makefile-based generators.<br>
I think the CMakeLists.txt for xcode should do the same.<br>
Modules/CMakeASM_NASMInformation.cmake lists .nasm and .asm as known file<br>
extensions.<br>
<br>
Alex<br>
</blockquote></div><br></div>