Within CTK, <br><br>Where we are specifying a specific SHA1, we could set UPDATE_COMMAND to be ""<br><br>Where we are specifying a branch like "origin/master", this is were the problem occurs. I guess we could also specify a given SHA1. This will prevent the external project to be a moving target and will ensure all developers will build using the same version of external projects.<br>
<br>What about specifying an SHA1 for external project like VTK, ITK, ... <br><br>Thanks<br>Jc<br><br><div class="gmail_quote">On Tue, Aug 2, 2011 at 7:28 AM, David Cole <span dir="ltr"><<a href="mailto:david.cole@kitware.com">david.cole@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">On Mon, Aug 1, 2011 at 5:59 PM, Sascha Zelzer<br>
<div><div></div><div class="h5"><<a href="mailto:s.zelzer@dkfz-heidelberg.de">s.zelzer@dkfz-heidelberg.de</a>> wrote:<br>
> Hi,<br>
><br>
> I played around with the ExternalProject unit tests and was able to<br>
> reproduce my problem with the current HEAD ExternalProjects.cmake file. It<br>
> boils down to *not* adding the UPDATE_COMMAND "" line:<br>
><br>
> 1.) In CMake/Tests/ExternalProject/CMakeLists.txt:487 remove (or comment in)<br>
> the UPDATE_COMMAND argument<br>
> 2.) Build the "TutorialStep1-GIT-bytag" project with VisualStudio 2010 (I am<br>
> using the Express Edition). You will get:<br>
><br>
> 1>------ Rebuild All started: Project: TutorialStep1-GIT-bytag,<br>
> Configuration: Debug Win32 ------<br>
> 1> Creating directories for 'TutorialStep1-GIT-bytag'<br>
> 1> Building Custom Rule<br>
> C:/Development/git/CMake/Tests/ExternalProject/CMakeLists.txt<br>
> 1> CMake does not need to re-run because<br>
> C:\Development\build\ExternalProject-Test\CMakeFiles\generate.stamp is<br>
> up-to-date.<br>
> 1> Performing download step (git clone) for 'TutorialStep1-GIT-bytag'<br>
> 1> Cloning into TutorialStep1-GIT-bytag...<br>
> 1> done.<br>
> 1> Note: checking out 'origin/master'.<br>
> 1><br>
> 1> You are in 'detached HEAD' state. You can look around, make experimental<br>
> 1> changes and commit them, and you can discard any commits you make in<br>
> this<br>
> 1> state without impacting any branches by performing another checkout.<br>
> 1><br>
> 1> If you want to create a new branch to retain commits you create, you may<br>
> 1> do so (now or later) by using -b with the checkout command again.<br>
> Example:<br>
> 1><br>
> 1> git checkout -b new_branch_name<br>
> 1><br>
> 1> HEAD is now at d197073... Initial import into repo.<br>
> 1> Performing update step (git fetch) for 'TutorialStep1-GIT-bytag'<br>
> ========== Rebuild All: 1 succeeded, 0 failed, 0 skipped ==========<br>
><br>
> So all other steps after the update step are ignored.<br>
><br>
> In CTK, we rely on the default update command for git and it works in Visual<br>
> Studio 2008. Any ideas how to fix this will be greatly appreciated.<br>
><br>
> Thanks,<br>
> Sascha<br>
><br>
><br>
><br>
> On 07/29/2011 12:40 PM, David Cole wrote:<br>
><br>
> Can you send along the output that you do see when your project is<br>
> downloading, and the build output that immediately follows that? Does it say<br>
> anything about the steps that come after download....?<br>
><br>
> For example, when I build the ExternalProject test and build only the<br>
> project "TutorialStep5-Local", I get the following output:<br>
><br>
> 1> Performing download step (DIR copy) for 'TutorialStep5-Local'<br>
> 1> No update step for 'TutorialStep5-Local'<br>
> 1> No patch step for 'TutorialStep5-Local'<br>
> 1> Performing configure step for 'TutorialStep5-Local'<br>
> 1> loading initial cache file C:/Users/davidcole/Dashboards/My<br>
> Tests/b20/CMakeExternals/tmp/TutorialStep5-Local/TutorialStep5-Local-cache.cmake<br>
> 1> -- Check for working C compiler using: Visual Studio 10<br>
> 1> -- Check for working C compiler using: Visual Studio 10 -- works<br>
> 1> -- Detecting C compiler ABI info<br>
> 1> -- Detecting C compiler ABI info - done<br>
> 1> -- Check for working CXX compiler using: Visual Studio 10<br>
> 1> -- Check for working CXX compiler using: Visual Studio 10 -- works<br>
> 1> -- Detecting CXX compiler ABI info<br>
> 1> -- Detecting CXX compiler ABI info - done<br>
> 1> -- Looking for log<br>
> 1> -- Looking for log - found<br>
> 1> -- Looking for exp<br>
> 1> -- Looking for exp - found<br>
> 1> -- Configuring done<br>
> 1> -- Generating done<br>
> 1> -- Build files have been written to: C:/Users/davidcole/Dashboards/My<br>
> Tests/b20/CMakeExternals/Build/TutorialStep5-Local<br>
> 1> Performing build step for 'TutorialStep5-Local'<br>
> .....<br>
><br>
><br>
> Do you see any "Performing XXX step" or "No XXX step" output after the<br>
> download occurs...?<br>
><br>
><br>
><br>
> On Fri, Jul 29, 2011 at 6:30 AM, David Cole <<a href="mailto:david.cole@kitware.com">david.cole@kitware.com</a>> wrote:<br>
>><br>
>> Is your VS 2010 in German by any chance? (Or the path name to the<br>
>> installation of VS 2010?)<br>
>><br>
>> We do not typically test on non-English platforms or build tools...<br>
>><br>
>><br>
>> On Fri, Jul 29, 2011 at 2:14 AM, Sascha Zelzer<br>
>> <<a href="mailto:s.zelzer@dkfz-heidelberg.de">s.zelzer@dkfz-heidelberg.de</a>> wrote:<br>
>>><br>
>>> Hi,<br>
>>><br>
>>> Thanks David and Yuri for the information. In my case (with CTK), there<br>
>>> are no error messages. The download step is successfully completed and the<br>
>>> following steps are just skipped. VS then reports that everything was<br>
>>> successfull (or up-to-date).<br>
>>><br>
>>> I will play with your test cases and my VS 2010 installation.<br>
>>><br>
>>> Thanks,<br>
>>> Sascha<br>
>>><br>
>>> On 07/29/2011 12:30 AM, David Cole wrote:<br>
>>>><br>
>>>> The ExternalProject test in the CMake test suite passes on Visual Studio<br>
>>>> 2010.<br>
>>>><br>
>>>> You can see all the variations of ExternalProject usage the test tries<br>
>>>> in this file:<br>
>>>><br>
>>>> <a href="http://cmake.org/gitweb?p=cmake.git;a=blob;f=Tests/ExternalProject/CMakeLists.txt;h=4a542d722ff127e672a63082c6bb35de1f3ef9cd;hb=b6fb213ed1431321fab0705beb3aae82f451dcc8" target="_blank">http://cmake.org/gitweb?p=cmake.git;a=blob;f=Tests/ExternalProject/CMakeLists.txt;h=4a542d722ff127e672a63082c6bb35de1f3ef9cd;hb=b6fb213ed1431321fab0705beb3aae82f451dcc8</a><br>
>>>><br>
>>>> Are there any error messages you get? Or are steps just skipped?<br>
>>>><br>
>>>> ??<br>
>>>> David<br>
>>>><br>
>>>><br>
>>>> On Wed, Jul 27, 2011 at 11:38 PM, Yuri Timenkov<<a href="mailto:yuri@timenkov.ru">yuri@timenkov.ru</a>><br>
>>>> wrote:<br>
>>>>><br>
>>>>> I'm not sure I understood your question, but now I use ExternalProject<br>
>>>>> (from<br>
>>>>> CMake 2.8.4) with Visual Studio 2010 which has 2 externals: one built<br>
>>>>> with<br>
>>>>> custom command (the C# project) and the second one is CMake-based but<br>
>>>>> with<br>
>>>>> VC6 generator. Everything compiles and works fine. But I don't have<br>
>>>>> download<br>
>>>>> step - everything is in my source directory.<br>
>>>>><br>
>>>>> The only wish I have I filed to Mantis:<br>
>>>>> <a href="http://public.kitware.com/Bug/view.php?id=12322" target="_blank">http://public.kitware.com/Bug/view.php?id=12322</a><br>
>>>>><br>
>>>>> Regards,<br>
>>>>> Yuri<br>
>>>>><br>
>>>>> On Thu, Jul 28, 2011 at 12:37 AM, Sascha Zelzer<br>
>>>>> <<a href="mailto:s.zelzer@dkfz-heidelberg.de">s.zelzer@dkfz-heidelberg.de</a>> wrote:<br>
>>>>>><br>
>>>>>> Hi,<br>
>>>>>><br>
>>>>>> Is nobody on this list using CTK or Slicer with Visual Studio 2010 in<br>
>>>>>> superbuild mode? If you do, could you please post if you had success<br>
>>>>>> or not?<br>
>>>>>><br>
>>>>>> Thanks,<br>
>>>>>> Sascha<br>
>>>>>><br>
>>>>>> On 07/22/2011 06:20 PM, Jean-Christophe Fillion-Robin wrote:<br>
>>>>>><br>
>>>>>> Hi Folks,<br>
>>>>>><br>
>>>>>> Before digging further into the problem ... if some your experience<br>
>>>>>> issue<br>
>>>>>> with VS2010 and superbuild .. would be great if you could provide more<br>
>>>>>> details about your investigation.<br>
>>>>>><br>
>>>>>> Thanks<br>
>>>>>> Jc<br>
>>>>>><br>
>>>>>> ---------- Forwarded message ----------<br>
>>>>>> From: Sascha Zelzer<<a href="mailto:s.zelzer@dkfz-heidelberg.de">s.zelzer@dkfz-heidelberg.de</a>><br>
>>>>>> Date: Fri, Jul 22, 2011 at 12:07 PM<br>
>>>>>> Subject: Re: [Ctk-developers] VS2010 support<br>
>>>>>> To: <a href="mailto:ctk-developers@commontk.org">ctk-developers@commontk.org</a><br>
>>>>>><br>
>>>>>><br>
>>>>>> Hi,<br>
>>>>>><br>
>>>>>> there is something very strange going on. The generated VS 2010<br>
>>>>>> projects<br>
>>>>>> (I am using the Express editions, 32bit) for the external dependencies<br>
>>>>>> like<br>
>>>>>> DCMTK, Log4Qt, etc. only call the download step of the<br>
>>>>>> ExternalProject_add<br>
>>>>>> call in our superbuild scripts. The projects are not configured and<br>
>>>>>> build.<br>
>>>>>><br>
>>>>>> Did anybody experience the same? I tried with and without the VS 2010<br>
>>>>>> SP1<br>
>>>>>> and with CMake 2.8.4 and 2.8.5.<br>
>>>>>><br>
>>>>>> Thanks,<br>
>>>>>> Sascha<br>
>>>>>><br>
>>>>>> On 07/22/2011 01:39 PM, Sascha Zelzer wrote:<br>
>>>>>>><br>
>>>>>>> Hi Folks,<br>
>>>>>>><br>
>>>>>>> I would like to get Visual Studio 2010 compatibility for CTK.<br>
>>>>>>><br>
>>>>>>> Currently, it looks like I will have to copy ExternalProject.cmake to<br>
>>>>>>> CTK for the CMAKE_CACHE_ARGS argument. Then a couple of small<br>
>>>>>>> modifications should do.<br>
>>>>>>><br>
>>>>>>> Any other ideas or objections?<br>
>>>>>>><br>
>>>>>>> Thanks,<br>
>>>>>>><br>
>>>>>>> Sascha<br>
>>>>>>> _______________________________________________<br>
>>>>>>> Ctk-developers mailing list<br>
>>>>>>> <a href="mailto:Ctk-developers@commontk.org">Ctk-developers@commontk.org</a><br>
>>>>>>> <a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
>>>>>><br>
>>>>>> _______________________________________________<br>
>>>>>> Ctk-developers mailing list<br>
>>>>>> <a href="mailto:Ctk-developers@commontk.org">Ctk-developers@commontk.org</a><br>
>>>>>> <a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
>>>>>><br>
>>>>>><br>
>>>>>><br>
>>>>>> --<br>
>>>>>> <a href="tel:%2B1%20919%20869%208849" value="+19198698849">+1 919 869 8849</a><br>
>>>>>><br>
>>>>>><br>
>>>>>><br>
>>>>>> _______________________________________________<br>
>>>>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>>>>><br>
>>>>>> Visit other Kitware open-source projects at<br>
>>>>>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>>>>><br>
>>>>>> Please keep messages on-topic and check the CMake FAQ at:<br>
>>>>>> <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
>>>>>><br>
>>>>>> Follow this link to subscribe/unsubscribe:<br>
>>>>>> <a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
>>>>><br>
>>>>> _______________________________________________<br>
>>>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>>>><br>
>>>>> Visit other Kitware open-source projects at<br>
>>>>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>>>><br>
>>>>> Please keep messages on-topic and check the CMake FAQ at:<br>
>>>>> <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
>>>>><br>
>>>>> Follow this link to subscribe/unsubscribe:<br>
>>>>> <a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
>>>>><br>
>>><br>
>><br>
><br>
><br>
><br>
<br>
</div></div>Thanks for this info... I've reproduced the problem now, too. I'm not<br>
sure what to do about it yet, but I can make it happen: that's the<br>
first step toward a fix.<br>
<br>
There should not be a need for an update step if you're snapped to<br>
particular hash or non-tracking branch/tag, though, should there? So,<br>
this seems like a contrived case to me.<br>
<br>
In the real project where this is happening, what git branch are you<br>
tracking that makes this a real problem...?<br>
<br>
<br>
Thanks,<br>
<font color="#888888">David<br>
</font><div><div></div><div class="h5">_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>+1 919 869 8849<br><br>