The proposed patch should be produced with:<div><br></div><div> git format-patch -1<br><br></div><div>(or -2, or -3, etc. if there is more than one commit...)</div><div><br></div><div><br><div class="gmail_quote">On Wed, Jun 15, 2011 at 3:52 PM, David Cole <span dir="ltr"><<a href="mailto:david.cole@kitware.com">david.cole@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Please open a bug report here:<div><a href="http://public.kitware.com/Bug" target="_blank">http://public.kitware.com/Bug</a></div>
<div><br></div><div>And attach the proposed patch as an attachment to the bug tracker entry...</div><div><br>
</div><div><br></div><div>Thanks,</div><div>David</div><div><div></div><div class="h5"><div><br><br><div class="gmail_quote">On Wed, Jun 15, 2011 at 3:50 PM, MALIK Julien <span dir="ltr"><<a href="mailto:julien.malik@c-s.fr" target="_blank">julien.malik@c-s.fr</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
I have one small patch available here : <a href="https://github.com/julienmalik/CMake/tree/FixFindSWIG" target="_blank">https://github.com/julienmalik/CMake/tree/FixFindSWIG</a><br>
<br>
I read through <a href="http://www.cmake.org/Wiki/CMake/Git" target="_blank">http://www.cmake.org/Wiki/CMake/Git</a> and <a href="http://public.kitware.com/Wiki/Git/Workflow/Topic" target="_blank">http://public.kitware.com/Wiki/Git/Workflow/Topic</a> but could not find the instructions for "I'm no CMake dev but have a small patch to contribute".<br>
If I have it available on github, what's the next step ?<br>
<br>
Regards,<br>
Julien<div><div></div><div><br>
<br>
<br>
Quoting David Cole <<a href="mailto:david.cole@kitware.com" target="_blank">david.cole@kitware.com</a>>:<br>
<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div></div><div>
The CMake 2.8.5 release candidate stream continues! You can find the<br>
source and binaries here: <a href="http://www.cmake.org/files/v2.8/?C=M;O=D" target="_blank">http://www.cmake.org/files/v2.8/?C=M;O=D</a><br>
<br>
Since we switched to git, and a new workflow, we're expecting to do<br>
more frequent releases. Because of that, our release candidate phases<br>
will be shorter than they have been historically. So, if you want to<br>
test this out and ask for a fix, do it soon, or hold your peace till<br>
the next release! I expect we will finalize the 2.8.5 release within<br>
the next week.<br>
<br>
Following is the list of changes in this release. Since we switched to<br>
git, this list is now the 'git log' one line summary written by the<br>
named CMake developers.<br>
<br>
Please try this version of CMake on your projects and report any<br>
issues to the list or the bug tracker.<br>
<br>
Happy building!<br>
-Dave<br>
<br>
<br>
Changes in CMake 2.8.5-rc2 (since 2.8.5-rc1)<br>
--------------------------------------------<br>
Bill Hoffman (6):<br>
Fix a memory leak.<br>
Fix for bug#10798. VS10 did not append -I flags with COMPILE_FLAGS prop.<br>
Append and do not clobber CMAKE_CXX_FLAGS in the test.<br>
Use bin tree for inclues to avoid -I with spaces in the path.<br>
One more try. Use full path by default, and relative on broken compilers.<br>
Fix for bug #11927, external project git clone step always runs vs10.<br>
<br>
Brad King (9):<br>
XL: Place Fortran modules with -qmoddir= flag (#12246)<br>
Teach file(DOWNLOAD|UPLOAD) to timeout after inactivity<br>
Xcode: Fix parallel build depends with universal binaries (#11844)<br>
Fix style errors added by parent and grandparent<br>
Use cascading-if for per-config test and install code<br>
CTest: Report tests not run due to unknown configuration<br>
GNU: Fix CMAKE_INCLUDE_SYSTEM_FLAG_<lang> value (#12258)<br>
Teach find_(library|package) about Linux multiarch (#12037)<br>
Test find_package multiarch support (#12037)<br>
<br>
Clinton Stimpson (11):<br>
BundleUtilities: Work w/ non .app exes on Mac (#12034)<br>
BundleUtilities: Fix regex to extract dependents from ldd (#12034)<br>
BundleUtilities: Fix test when using xcode (#12034)<br>
BundleUtilities: Fix issues with custom target DEPENDS in test (#12034)<br>
BundleUtilities: Disable running test on Windows unless using MSVC.<br>
BundleUtilities: Run test on Windows if either MSVC or dumpbin was found.<br>
BundleUtilities: Print reason for not loading module.so<br>
BundleUtilities: Add rpath to loadable modules in test.<br>
Revert "BundleUtilities: Run test on Windows if either MSVC or<br>
dumpbin was found."<br>
Qt4: complete module dependencies in UseQt4.cmake<br>
Add imported targets support for frameworks on Mac.<br>
<br>
Daniel R. Gomez (1):<br>
Fix plugin API for gcc 2.9-aix51-020209 (#12233)<br>
<br>
David Cole (3):<br>
BundleUtilities: Avoid a cryptic and unhelpful error message<br>
BundleUtilities: Avoid test on Watcom dashboards (#12034)<br>
CMake: eliminate use of cvs in the Release scripts<br>
<br>
Eric NOULARD (2):<br>
CPackRPM: Enhance documentation<br>
Add some more Specs file tag handling.<br>
<br>
Johan Björk (3):<br>
CMake: Move tokenize to cmSystemTools<br>
Xcode: Support multiple level nesting of XCode folders (#10039)<br>
XCode: Support target folders on XCode.<br>
<br>
Modestas Vainius (1):<br>
multiarch: Set CMAKE_LIBRARY_ARCHITECTURE_REGEX for Linux|Hurd|kFreeBSD<br>
<br>
Philip Lowman (3):<br>
FindProtobuf: Better MSVC support, Searching for protobuf lite<br>
Fix , to - in Copyright message so it passes CMake.ModuleNotices test<br>
10997: PROTOBUF_GENERATE_CPP now supports proto files outside current dir<br>
<br>
Rolf Eike Beer (1):<br>
CMake: Update documentation of STRING(SUBSTRING) for length -1 (#10740)<br>
<br>
Sean McBride (1):<br>
Fix XCode -> Xcode typos, notably in man page (#12231)<br>
<br>
Tim Gallagher (1):<br>
Modified the FindHDF5.cmake file to locate the Fortran bindings.<br>
<br>
Will Dicharry (7):<br>
HDF5 high level library is a find COMPONENT now.<br>
Add logic for CMake built HDF5 install.<br>
Use CMAKE_CURRENT_LIST_DIR to locate FindPackageHandleStandardArgs.<br>
Use HDF5_FOUND to control autoconf and CMake built FindHDF5.<br>
Fix for bug 11752, mixed debug and release libraries.<br>
FindHDF5 ensures good link lines when libraries are duplicated.<br>
Remove unnecessary mark_as_advanced from FindHDF5.<br>
<br>
Zach Mullen (3):<br>
Dynamic analysis test output should not be compressed.<br>
We will actually compress memcheck output if the server supports it.<br>
Fix type conversion warning<br></div></div><div>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
<br>
<br>
</div></blockquote>
<br>
<br>
<br>
----------------------------------------------------------------<br>
This message was sent using IMP, the Internet Messaging Program.<br>
<br>
<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>