<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hi,<br>
<br>
Am 09.06.2011 13:20, schrieb Michael Wild:<br>
<span style="white-space: pre;">> On 06/09/2011 01:11 PM, Rolf
Eike Beer wrote:<br>
>>> Hi,<br>
>>><br>
>>> I just notied that CTest 2.8.4 incorrectly parses
valgrind's memcheck<br>
>>> output because it does not always take into account
that numbers<br>
>>> reported by valgrind can be larger than 1,000 and
then will contain a<br>
>>> comma as thousand-delimiter. Therefore, many
errors/potential errors<br>
>>> are not correctly reported in the dashboard.<br>
>>><br>
>>> Am I missing anything?<br>
>>><br>
>>> The attached patch solves the problem. I hope I
caught all cases.<br>
>>> Should I open a bug report for this?<br>
>><br>
>> Yes. And please use unified diff format. Preferred is
if you could do a<br>
>> checkout of CMake git and commit your patch (locally)
and then do "git<br>
>> format-patch HEAD^" and attach the resulting 0001-*
file to the bug.<br>
>><br>
>> Just from a quick look: shouldn't the regex be
something like<br>
>> [0-9]*(,[0-9]*)*?<br>
>><br>
>> Eike<br>
><br>
><br>
> Isn't the separator locale-dependent? What does the output
look like if<br>
> LC_ALL=C?</span><br>
Don't know, does valgrind take this into account? I just used the
same<br>
regex that was already used in _some_ expressions (e.g. the<br>
direct/indirect entry) and put in all (?) other locations where it<br>
might be required.<br>
<br>
@Eike: About the parens in the regex: I don't see how 100 %
correct<br>
parsing is required anyway. IMHO it is sufficient to be able to<br>
distinguish between the different valgrind events and not to<br>
accidentally include some console output of the test exectuable
itself.<br>
<br>
I will try my best with the you git suggestions (though I am an<br>
absolute git newbie.....)<br>
<br>
Johannes<br>
<br>
<br>
</body>
</html>