<div class="gmail_quote">On Wed, Nov 3, 2010 at 5:09 PM, Eric Noulard <span dir="ltr"><<a href="mailto:eric.noulard@gmail.com">eric.noulard@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
2010/11/3 Bill Hoffman <<a href="mailto:bill.hoffman@kitware.com">bill.hoffman@kitware.com</a>>:<br>
<div class="im">><br>
> The reason this is showing up is because they are compiling a .h file:<br>
><br>
> LIST(APPEND LIBHLA_EXPORTED_INCLUDES sha1.h)<br>
> set_source_files_properties(sha1.c sha1.h PROPERTIES LANGUAGE "C")<br>
> SOURCE_GROUP("Source Files\\Hash" FILES ${LIBHLA_HASH_SRCS})<br>
><br>
><br>
> The sha1.h is being set to a C source file. It is a bug, and the patch<br>
> should fix it.<br>
<br>
</div>I'll try the patch.<br>
<div class="im"><br>
> However, seems odd to be compiling a .h file.<br>
<br>
</div>What do you mean by "compiling" a header?<br>
<br>
I usually do<br>
<br>
add_library(mylib file1.c file1.h file2.c file2.h)<br>
or<br>
add_executable(myexe mysource.c anyother.h)<br>
etc...<br>
<br>
what's wrong/odd with that I thought CMake would sort it out<br>
what is an header and what is not ?<br>
<br>
Or do you mean that the<br>
<div class="im">set_source_files_properties(sha1.c sha1.h PROPERTIES LANGUAGE "C")<br>
<br>
</div>is telling CMake that "sha1.h" should be compiled?<br>
<br>
I thought I was (because I'm the culprit) telling CMake that thoses file<br>
were C files (either header or to-be-compiled sources)?<br>
<br>
Am I wrong?<br>
<div class="im"><br>
<br>
--<br>
Erk<br>
Membre de l'April - « promouvoir et défendre le logiciel libre » -<br>
<a href="http://www.april.org" target="_blank">http://www.april.org</a><br>
</div><div><div></div><div class="h5">_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
</div></div></blockquote></div><br><br>It should be fine. CMake should handle .h files that have this property set. We should fix it. (And we will -- probably in the 2.8.4 release.)<br><br>But, for now, you should be able to work around it on your side by removing the sha.1 from the list of files in your set_source_files_properties call.<br>
<br><br>HTH,<br>David<br><br>