<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]-->
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:blue;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:Arial;
color:gray;
font-weight:bold;
font-style:normal;
text-decoration:none none;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:Arial;
color:gray;
font-weight:bold;
font-style:normal;
text-decoration:none none;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=EN-US link=blue vlink=blue>
<div class=Section1>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'>Done:
Issue 0011292<o:p></o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'><o:p> </o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'>Cheers!<o:p></o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'><o:p> </o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'>--aaron<o:p></o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'><o:p> </o:p></span></font></b></p>
<div>
<div style='border:none;border-top:dotted silver 1.0pt;padding:4.0pt 0in 0in 0in'>
<p class=MsoNormal><b><font size=1 color="#666666" face=Arial><span
style='font-size:9.0pt;font-family:Arial;color:#666666;font-weight:bold'>Aaron
C. Meadows</span></span></font></b><font size=1 color="#666666" face=Arial><span
style='font-size:9.0pt;font-family:Arial;color:#666666'> </span></font><font
size=1 color="#666666" face=Arial><span style='font-size:9.0pt;font-family:
Arial;color:#666666'><o:p></o:p></span></font></p>
</div>
</div>
<div>
<div class=MsoNormal align=center style='text-align:center'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>
<hr size=2 width="100%" align=center tabindex=-1>
</span></font></div>
<p class=MsoNormal><b><font size=2 face=Tahoma><span style='font-size:10.0pt;
font-family:Tahoma;font-weight:bold'>From:</span></font></b><font size=2
face=Tahoma><span style='font-size:10.0pt;font-family:Tahoma'>
cmake-bounces@cmake.org [mailto:cmake-bounces@cmake.org] <b><span
style='font-weight:bold'>On Behalf Of </span></b>Meadows, Aaron C.<br>
<b><span style='font-weight:bold'>Sent:</span></b> Tuesday, October 05, 2010
9:24 AM<br>
<b><span style='font-weight:bold'>To:</span></b> philip@yhbt.com<br>
<b><span style='font-weight:bold'>Cc:</span></b> cmake@cmake.org<br>
<b><span style='font-weight:bold'>Subject:</span></b> Re: [CMake]
CMakeDetermineVSServicePack.cmake support for vs2010</span></font><o:p></o:p></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'>I can
try and take a look at it. I actually tried it in a hacky sort of way and
it worked great, but I wasn’t using CMake’s variable for the
compiler, etc… I used execute_process() and didn’t have any
issues with ‘cl /?’ waiting on input. It shaved off several
seconds with the hacked-together version I tried. I’ll see
what I can do.<o:p></o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'><o:p> </o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'>--aaron<o:p></o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'><o:p> </o:p></span></font></b></p>
<div>
<div style='border:none;border-top:dotted silver 1.0pt;padding:4.0pt 0in 0in 0in'>
<p class=MsoNormal><b><font size=1 color="#666666" face=Arial><span
style='font-size:9.0pt;font-family:Arial;color:#666666;font-weight:bold'>Aaron
C. Meadows</span></font></b><font size=1 color="#666666" face=Arial><span
style='font-size:9.0pt;font-family:Arial;color:#666666'> <o:p></o:p></span></font></p>
</div>
</div>
<div>
<div class=MsoNormal align=center style='text-align:center'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>
<hr size=2 width="100%" align=center tabindex=-1>
</span></font></div>
<p class=MsoNormal><b><font size=2 face=Tahoma><span style='font-size:10.0pt;
font-family:Tahoma;font-weight:bold'>From:</span></font></b><font size=2
face=Tahoma><span style='font-size:10.0pt;font-family:Tahoma'>
philiplowman@gmail.com [mailto:philiplowman@gmail.com] <b><span
style='font-weight:bold'>On Behalf Of </span></b>Philip Lowman<br>
<b><span style='font-weight:bold'>Sent:</span></b> Thursday, September 30, 2010
8:44 PM<br>
<b><span style='font-weight:bold'>To:</span></b> Meadows, Aaron C.<br>
<b><span style='font-weight:bold'>Cc:</span></b> cmake@cmake.org<br>
<b><span style='font-weight:bold'>Subject:</span></b> Re: [CMake]
CMakeDetermineVSServicePack.cmake support for vs2010</span></font><o:p></o:p></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
<div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>On Thu, Sep 30, 2010 at 11:04 AM, <<a
href="mailto:aaron.meadows@thomsonreuters.com">aaron.meadows@thomsonreuters.com</a>>
wrote:<o:p></o:p></span></font></p>
</div>
</div>
<div>
<div>
<blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;
margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt'>
<div link=blue vlink=blue>
<div>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'>Done. Issue number 11279. [<a
href="http://public.kitware.com/Bug/view.php?id=11279" target="_blank">http://public.kitware.com/Bug/view.php?id=11279</a>]</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'> </span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'>I also noted that the script could be improved by
calling the compiler with the ‘/?’ switch and parsing it’s
output instead of parsing the output from try_compile’ing a simple c file
it writes. That would make it quite a bit faster.</span></font></b><o:p></o:p></p>
</div>
</div>
</blockquote>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
</div>
<div>
<div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>Aaron,<o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>Thanks for the patch. I've pushed it to git next.<o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>Regarding your idea to use the output of "cl /?" to determine
the version number, I think it is a good one. If you have time to rewrite the
module to do this instead and test it I would merge the changes for a future
version of CMake.<o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>Some potential issues.<o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>1. "cl /?" appears to pause waiting for input, this would have
to be mitigated somehow in a safe way or perhaps just "cl" could be
executed as that appears to include the output.<o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>2. "cl" or "cl /?" output would have to be verified
on VS8 to ensure it outputs there as well (it appears to be there in
VS9/Express)<o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>3. You couldn't just run "cl", you would have to find out the
CMake variable for the compiler and run that.<o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>My time is really limited. If you're interested, please create a new
ticket and submit a patch. It would save probably at least a second off of an
initial configure.<o:p></o:p></span></font></p>
</div>
</div>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
</div>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>-- <br>
Philip Lowman<o:p></o:p></span></font></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><br clear=all>
This email was sent to you by Thomson Reuters, the global news and information
company.<br>
Any views expressed in this message are those of the individual sender, except
where the sender specifically states them to be the views of Thomson Reuters. <o:p></o:p></span></font></p>
</div>
<br clear=all> This email was sent to you by Thomson Reuters, the global news and information company.<br>
Any views expressed in this message are those of the individual sender, except where the sender specifically states them to be the views of Thomson Reuters.
</body>
</html>