<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:st1="urn:schemas-microsoft-com:office:smarttags" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]--><o:SmartTagType
namespaceuri="urn:schemas-microsoft-com:office:smarttags" name="City"/>
<o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags"
name="place"/>
<!--[if !mso]>
<style>
st1\:*{behavior:url(#default#ieooui) }
</style>
<![endif]-->
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:blue;
text-decoration:underline;}
p
{mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:Arial;
color:gray;
font-weight:bold;
font-style:normal;
text-decoration:none none;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=EN-US link=blue vlink=blue>
<div class=Section1>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'>Done. Issue
number 11279. [http://public.kitware.com/Bug/view.php?id=11279]<o:p></o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'><o:p> </o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'>I also
noted that the script could be improved by calling the compiler with the ‘/?’
switch and parsing it’s output instead of parsing the output from
try_compile’ing a simple c file it writes. That would make it quite a
bit faster.<o:p></o:p></span></font></b></p>
<p class=MsoNormal><b><font size=2 color=gray face=Arial><span
style='font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold'><o:p> </o:p></span></font></b></p>
<div>
<div style='border:none;border-top:dotted silver 1.0pt;padding:4.0pt 0in 0in 0in'>
<p class=MsoNormal><b><font size=1 color="#666666" face=Arial><span
style='font-size:9.0pt;font-family:Arial;color:#666666;font-weight:bold'>Aaron
C. Meadows</span></span></font></b><font size=1 color="#666666" face=Arial><span
style='font-size:9.0pt;font-family:Arial;color:#666666'> </span></font><font
size=1 color="#666666" face=Arial><span style='font-size:9.0pt;font-family:
Arial;color:#666666'><o:p></o:p></span></font></p>
</div>
</div>
<div>
<div class=MsoNormal align=center style='text-align:center'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>
<hr size=2 width="100%" align=center tabindex=-1>
</span></font></div>
<p class=MsoNormal><b><font size=2 face=Tahoma><span style='font-size:10.0pt;
font-family:Tahoma;font-weight:bold'>From:</span></font></b><font size=2
face=Tahoma><span style='font-size:10.0pt;font-family:Tahoma'>
philiplowman@gmail.com [mailto:philiplowman@gmail.com] <b><span
style='font-weight:bold'>On Behalf Of </span></b>Philip Lowman<br>
<b><span style='font-weight:bold'>Sent:</span></b> Thursday, September 30, 2010
7:25 AM<br>
<b><span style='font-weight:bold'>To:</span></b> Meadows, Aaron C.<br>
<b><span style='font-weight:bold'>Cc:</span></b> cmake@cmake.org<br>
<b><span style='font-weight:bold'>Subject:</span></b> Re: [CMake]
CMakeDetermineVSServicePack.cmake support for vs2010</span></font><o:p></o:p></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>Aaron,<o:p></o:p></span></font></p>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>Thanks for posting. Could you open a new bug report and attach
your patch to it?<o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
</div>
<div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>On Wed, Sep 29, 2010 at 9:33 PM, <<a
href="mailto:aaron.meadows@thomsonreuters.com">aaron.meadows@thomsonreuters.com</a>>
wrote:<o:p></o:p></span></font></p>
<div link=blue vlink=purple>
<div>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'>Hi all. I noticed that CMakeDetermineVSServicePack.cmake
only supports vs2005, vs2005 sp1, vs2008, vs2008 sp1. I wanted to use it
for vs2010.</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'> </span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'>I looked for a bug but the only one I found was
the one that resulted in the scripts creation: <a
href="http://public.kitware.com/Bug/view.php?id=8803" target="_blank">http://public.kitware.com/Bug/view.php?id=8803</a></span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'> </span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'>I have a patch to fix it: (also attached)</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'> </span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>***
CMakeDetermineVSServicePack.cmake 2010-06-28 09:42:36.000000000
-0500</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>---
CMakeDetermineVSServicePackWith2010.cmake 2010-09-29 20:26:20.530212900
-0500</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>***************</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>*** 47,52 ****</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>--- 47,54 ----</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>
set(_version "vc90")</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>
elseif(${_cl_version} VERSION_EQUAL "15.00.30729.01")</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>
set(_version "vc90sp1")</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>+
elseif(${_cl_version} VERSION_EQUAL "16.00.30319.01")</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>+
set(_version "vc100")</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>
else()</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>
set(_version "")</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;
margin-left:.5in'><b><font size=2 color=gray face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:gray;font-weight:bold'>
endif()</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'> </span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'>Should I open a new bug for this and add a patch
to it, or reopen the old bug (feature request) with this patch?</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'> </span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'>Thanks!</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'> </span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'>--aaron</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray;font-weight:bold'> </span></font></b><o:p></o:p></p>
<div style='border:none;border-top:dotted silver 1.0pt;padding:4.0pt 0in 0in 0in'>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><font
size=1 color="#666666" face=Arial><span style='font-size:9.0pt;font-family:
Arial;color:#666666;font-weight:bold'>Aaron Meadows</span></font></b><font
size=1 color="#666666" face=Arial><span style='font-size:9.0pt;font-family:
Arial;color:#666666'><br>
Software Engineer</span></font><o:p></o:p></p>
<p style='margin-bottom:9.0pt'><b><font size=1 color="#f57f20" face=Arial><span
style='font-size:9.0pt;font-family:Arial;color:#F57F20;font-weight:bold'>Thomson
Reuters</span></font></b><o:p></o:p></p>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><font
size=1 color="#666666" face=Arial><span style='font-size:9.0pt;font-family:
Arial;color:#666666'>Phone: 314.468.3530<br>
<st1:City w:st="on"><st1:place w:st="on">Mobile</st1:place></st1:City>:
636.541.6139<br>
<a href="mailto:aaron.meadows@thomsonreuters.com" target="_blank">aaron.meadows@thomsonreuters.com</a><br>
<a href="http://thomsonreuters.com" target="_blank">thomsonreuters.com</a></span></font><o:p></o:p></p>
</div>
<p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><font
size=3 face="Times New Roman"><span style='font-size:12.0pt'> <o:p></o:p></span></font></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><br clear=all>
This email was sent to you by Thomson Reuters, the global news and information
company.<br>
Any views expressed in this message are those of the individual sender, except
where the sender specifically states them to be the views of Thomson Reuters. <o:p></o:p></span></font></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a
href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a
href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><o:p></o:p></span></font></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><br>
<br clear=all>
<br>
-- <br>
Philip Lowman<o:p></o:p></span></font></p>
</div>
</div>
<br clear=all> This email was sent to you by Thomson Reuters, the global news and information company.<br>
Any views expressed in this message are those of the individual sender, except where the sender specifically states them to be the views of Thomson Reuters.
</body>
</html>