<div class="gmail_quote">On Thu, Jun 10, 2010 at 4:17 PM, Alan W. Irwin <span dir="ltr"><<a href="mailto:irwin@beluga.phys.uvic.ca">irwin@beluga.phys.uvic.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On 2010-04-09 12:17-0400 David Cole wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
A "real" fix for this has been committed to the CVS repository for kwsys.<br>
The change should appear in the CMake git repository shortly on 'master'...<br>
<br>
Thanks to Clinton Stimpson for the patch.<br>
<br>
<br>
cvs commit -m "Patch to avoid short name usage where possible. Get the<br>
actual case spelling of a file name on 'Windows' without converting to short<br>
name and back again. Avoids bad behavior reported in<br>
<a href="http://bugs.winehq.org/show_bug.cgi?id=22286" target="_blank">http://bugs.winehq.org/show_bug.cgi?id=22286</a> when using cmake under a<br>
wine/msys/mingw installation on a Linux box. Thanks to Clinton Stimpson for<br>
preparing the patch."<br>
<br>
/cvsroot/KWSys/KWSys/SystemTools.cxx,v <-- SystemTools.cxx<br>
new revision: 1.257; previous revision: 1.256<br>
</blockquote>
<br></div>
Hi David:<br>
<br>
Sorry for the long delay in responding to you. I am just now restarting<br>
testing of MinGW (4.5.0) and CMake-2.8.1 under Wine (1.1.42).<br>
<br>
I did find the patch at the "patch" link accessible from<br>
<a href="http://cmake.org/gitweb?p=cmake.git;a=commit;h=018c13ff73d9b7b151cb77f7adcbbb7be27f49d3" target="_blank">http://cmake.org/gitweb?p=cmake.git;a=commit;h=018c13ff73d9b7b151cb77f7adcbbb7be27f49d3</a><br>
<br>
I notice the following result after applying the patch<br>
<br>
software@raven> find -print0 -type f |xargs -0 grep -l shortPath<br>
./Source/kwsys/SystemTools.cxx<br>
<br>
Further investigation indicates bool SystemTools::GetShortPath is defined<br>
that appears to be unused anywhere else in the source tree now that the<br>
patch has been applied. Therefore, shouldn't that method be removed?<div><div></div><br></div></blockquote><div><br>kwsys code is shared among many, many projects. It appears in way more than just CMake. So removing a function from any of its interfaces is really probably not a very good idea. :-)<br>
<br><br>David<br><br></div></div>