On Thu, Jan 8, 2009 at 5:22 PM, Albert Astals Cid <span dir="ltr"><<a href="mailto:aacid@kde.org">aacid@kde.org</a>></span> wrote:<br><div class="gmail_quote"><div class="Wj3C7c"><br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Ok, so at the end it is<br>
<br>
find_path(LibOpenJPEG_INCLUDE_DIR openjpeg.h<br>
PATH_SUFFIXES openjpeg openjpeg-1.0)<br>
<br>
find_library(LibOpenJPEG_OPENJPEG_LIBRARY openjpeg)<br>
<br>
if (LibOpenJPEG_OPENJPEG_LIBRARY)<br>
set (LibOpenJPEG_LIBRARIES ${openjpeg_LIBRARY})<br>
endif (LibOpenJPEG_OPENJPEG_LIBRARY)</blockquote><div><br>If you spot any find modules with this syntax this is wrong. The reason why is if LibOpenJPEG_OPENJPEG_LIBRARY is NOTFOUND then LibOpenJPEG_LIBRARIES will not be set to NOTFOUND and if the user is linking a target against the LIBRARIES variable they will get no error because the variable will expand to nothing.<br>
<br>Please fix this in your new modules and if you see it anywhere report it as a bug.<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
But this noise in the list isn't worth if we don't get a proper ok/ko from the<br>
package maintainers regarding the fact of having this kind of FindFoo files<br>
in cmake upstream or not.</blockquote><div><br>I will happily check in FindOpenJPEG for you once it's cleaned up should you decide not to want to get CVS access and maintain it yourself. It's packaged in Debian which definitely qualifies it as used enough to check in.<br>
<br>As others have commented, please drop the "Lib" prefix unless the library is universally referred to as "libopenjpeg" in normal speech or if shortening it to just "openjpeg" would cause confusion. An example of a module that probably should keep the "lib" prefix currently in CVS would be FindLibXml2. Calling it FindXml or FindXml2 would just cause confusion. Unless this is the case with your module dropping the "lib" would be adviseable.<br>
<br></div></div>-- <br>Philip Lowman<br>