View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0015685

CMake

public

2015-08-05 13:21

2016-02-01 09:10

Reporter

Mourad

Assigned To

Clinton Stimpson

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Windows

OS Version

7 64bit

Product Version

CMake 3.3

Target Version

Fixed in Version

Summary

0015685: When packaging cmake-gui Qt dlls are resolved from the PATH and not from the Qt installation directory used to build CMake

Description

Hi,

I have two Qt versions installed on my system. The main one (64 bit build) is used for my other projects, and the second one (32bit build) is only used to build CMake.

When packaging/installing CMake-gui , the Qt dlls are resolved from my main Qt installation (because its bin folder is in my PATH, I guess), and not from the Qt installation folder that is used to build CMake.

IMHO, there is a typo in Source/QtDialog/CMakeLists.txt (see attached patch), which when solved, solves the problem.

Please note that there might also be a problem with the QT_LIBRARY_DIR variable (it's not used on Windows, maybe it is on other platforms)

Cheers,
Mourad

Tags

No tags attached.

Attached Files

cmake.patch [^] (603 bytes) 2015-08-05 13:21 [Show Content] [Hide Content]

diff --git "a/Source\\QtDialog\\CMakeLists.txt" "b/Source\\QtDialog\\CMakeLists.txt"
index ad6a7fb..53c45fe 100644
--- "a/Source\\QtDialog\\CMakeLists.txt"
+++ "b/Source\\QtDialog\\CMakeLists.txt"
@@ -223,7 +223,7 @@ if(CMake_INSTALL_DEPENDENCIES AND (APPLE OR WIN32))
   install(CODE "
     include(\"${CMake_SOURCE_DIR}/Modules/BundleUtilities.cmake\")
     set(BU_CHMOD_BUNDLE_ITEMS ON)
-    fixup_bundle(\"${fixup_exe}\" \"${QT_PLUGINS}\" \"${QT_LIBRARY_DIR};${QT_BINARY_DIR}\")
+    fixup_bundle(\"${fixup_exe}\" \"${QT_PLUGINS}\" \"${QT_LIBRARY_DIR};${Qt_BIN_DIR}\")
   " ${COMPONENT})
 endif()

Relationships

Notes
(0039253) Clinton Stimpson (developer) 2015-08-07 17:25	That is not a typo. QT_LIBRARY_DIR and QT_BINARY_DIR variables come from FindQt4.cmake. On Windows, dlls reside in the Qt/bin directory, while on other platforms under the Qt/lib directory. Both are given to fixup_bundle(). cmake-gui is still compiled with Qt4 by many users. The attached patch will break it for some of those users. For Qt5, it seems we should also remove QT_LIBRARY_DIR.

(0039268) Mourad (reporter) 2015-08-12 04:50	I'm using Qt5 (forgot to mention it), and for Qt5 both QT_BINARY_DIR and QT_LIBRARY_DIR are empty.

(0039270) Clinton Stimpson (developer) 2015-08-12 10:26	Yes, I was able to guess you were using Qt5. And yes, I do understand that QT_BINARY_DIR and QT_LIBRARY_DIR will be empty if using Qt5. For Qt4, we still need to use QT_BINARY_DIR and QT_LIBRARY_DIR (from FindQt4.cmake) For Qt5, we need to use Qt_BIN_DIR (from QtDialog/CMakeLists.txt) I'll let you fix up your patch if you'd like.

(0039439) Clinton Stimpson (developer) 2015-09-17 10:35	Fixed here: http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=851915a5 [^]

(0040410) Robert Maynard (manager) 2016-02-01 09:10	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2015-08-05 13:21	Mourad	New Issue
2015-08-05 13:21	Mourad	File Added: cmake.patch
2015-08-05 13:32	Brad King	Assigned To	=> Clinton Stimpson
2015-08-05 13:32	Brad King	Status	new => assigned
2015-08-05 13:32	Brad King	Target Version	=> CMake 3.4
2015-08-07 17:25	Clinton Stimpson	Note Added: 0039253
2015-08-12 04:50	Mourad	Note Added: 0039268
2015-08-12 10:26	Clinton Stimpson	Note Added: 0039270
2015-09-16 16:32	Brad King	Target Version	CMake 3.4 =>
2015-09-17 10:35	Clinton Stimpson	Note Added: 0039439
2015-09-18 12:16	Clinton Stimpson	Status	assigned => resolved
2015-09-18 12:16	Clinton Stimpson	Resolution	open => fixed
2016-02-01 09:10	Robert Maynard	Note Added: 0040410
2016-02-01 09:10	Robert Maynard	Status	resolved => closed